Fix Windows extension install from downloads.php.net#515
Open
GhostPirateBob wants to merge 2 commits intophp:1.4.xfrom
Open
Fix Windows extension install from downloads.php.net#515GhostPirateBob wants to merge 2 commits intophp:1.4.xfrom
GhostPirateBob wants to merge 2 commits intophp:1.4.xfrom
Conversation
- Generate asset name variants for "x64" arch (not just "x86_64") and versions without "v" prefix - Add Architecture::windowsName() for conventional Windows arch labels - Fall back to downloads.php.net/~windows/pecl/releases/ when GitHub release has no matching Windows binary - Support simple DLL naming (e.g. "php_apcu.dll") used in downloads.php.net zips
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #513
G'day folks!
This is my first contribution to this repo, so please let me know if there’s a preferred way to structure things.
I had a weird issue on Windows with the latest nightly and 1.3.8 stable where
pie install apcu/apcudidn't work, even though there was a valid zip file and dll for my version.Anyway turns out it was to do with inconsistent naming across different $arch so I made a PR to fix it.
I also ran into another weird build workflow issue while doing this PR, but I split it off into a second one because it was somewhat unrelated (see #514 and #512).
Cheers!
gpb
✌(◕‿-)✌
Summary
Architecture::allNames()returning all known name variants per architecture (e.g.x86_64+x64,arm64+aarch64), so asset filename matching works across platforms that use different conventionsWindowsExtensionAssetNameto generate filename variants covering all arch aliases and version formats (with/withoutvprefix), fixing installs from sources like downloads.php.netPrePackagedBinaryAssetNameandGithubPackageReleaseAssetsto useallNames()for broader asset matchingphp_<ext>.dll) used by downloads.php.netAfter fix: