Skip to content

server: check connection is available in SQLKiller#60685

Merged
ti-chi-bot[bot] merged 20 commits intopingcap:masterfrom
Defined2014:fix-57531-another
May 7, 2025
Merged

server: check connection is available in SQLKiller#60685
ti-chi-bot[bot] merged 20 commits intopingcap:masterfrom
Defined2014:fix-57531-another

Conversation

@Defined2014
Copy link
Copy Markdown
Contributor

@Defined2014 Defined2014 commented Apr 21, 2025

What problem does this PR solve?

Issue Number: close #57531

Problem Summary:

What changed and how does it work?

Check List

Tests

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Apr 21, 2025
@Defined2014 Defined2014 changed the title server: check connection is available in SQLKiller [WIP] server: check connection is available in SQLKiller Apr 21, 2025
@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 21, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2025

Codecov Report

Attention: Patch coverage is 94.82759% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.6238%. Comparing base (62d4284) to head (4f6c85b).
Report is 8 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #60685        +/-   ##
================================================
+ Coverage   73.1298%   73.6238%   +0.4940%     
================================================
  Files          1722       1722                
  Lines        476908     479248      +2340     
================================================
+ Hits         348762     352841      +4079     
+ Misses       106738     104885      -1853     
- Partials      21408      21522       +114     
Flag Coverage Δ
integration 42.5672% <59.6491%> (?)
unit 72.3806% <94.8275%> (+0.0297%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 47.4433% <ø> (+0.0164%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Defined2014
Copy link
Copy Markdown
Contributor Author

/retest

@tiprow
Copy link
Copy Markdown

tiprow Bot commented Apr 21, 2025

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Defined2014 Defined2014 changed the title [WIP] server: check connection is available in SQLKiller server: check connection is available in SQLKiller Apr 23, 2025
@ti-chi-bot ti-chi-bot Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 23, 2025
@Defined2014 Defined2014 requested review from YangKeao, bb7133 and xhebox May 6, 2025 06:19
@Defined2014
Copy link
Copy Markdown
Contributor Author

/retest

@tiprow
Copy link
Copy Markdown

tiprow Bot commented May 6, 2025

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Defined2014 Defined2014 requested a review from dveeden May 7, 2025 01:42
Copy link
Copy Markdown
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 7, 2025
Copy link
Copy Markdown
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

Comment thread pkg/server/internal/util/buffered_read_conn.go
Comment thread pkg/util/sqlkiller/sqlkiller.go Outdated
Comment thread pkg/server/internal/util/buffered_read_conn.go
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 7, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-07 02:17:29.130053346 +0000 UTC m=+407896.312956592: ☑️ agreed by YangKeao.
  • 2025-05-07 03:07:50.382192946 +0000 UTC m=+410917.565096205: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot Bot merged commit 89f9ca4 into pingcap:master May 7, 2025
24 checks passed
@Defined2014 Defined2014 deleted the fix-57531-another branch May 7, 2025 03:45
bb7133 pushed a commit to bb7133/tidb that referenced this pull request Jan 28, 2026
@King-Dylan King-Dylan added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label May 7, 2026
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #68201.
But this PR has conflicts, please resolve them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TiDB can't close connection immediately after killing client process

5 participants