fix(web): close reasoning picker after selection#4523
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Straightforward UI fix adding an optional You can customize Macroscope's approvability policy. Learn more. |
Fixes #4522
What Changed
TraitsMenuContentconsumers.Why
Selecting a reasoning level updates the value, but the controlled picker remains open. The selection handlers update the underlying state without requesting that the parent menu close.
Passing an optional close callback into the menu content keeps the change scoped to the picker while restoring the expected single-selection menu behavior.
UI Changes
Before
reasoning-picker-before.mp4
After
reasoning-picker-after.mp4
Verified in the web client with both Claude and Codex reasoning options.
Checklist
Note
Close reasoning picker menu after trait selection
The traits picker menu previously stayed open after a user selected a value. Now,
TraitsMenuContentcalls an optionalonRequestClosecallback after any selection (trait value, boolean toggle, or prompt-injected value), andTraitsPickerpasses a handler that sets menu open state to false.Macroscope summarized 9a5f32b.
Note
Low Risk
Small UI interaction fix in TraitsPicker with an optional callback; no auth, data, or persistence changes.
Overview
The traits picker menu stayed open after choosing a reasoning level or other trait.
TraitsMenuContentnow accepts an optionalonRequestCloseand invokes it after a successful select change (including Ultrathink / prompt-injected options) and after boolean On/Off picks.TraitsPickerpassesonRequestClose={() => setIsMenuOpen(false)}so the controlled menu closes on each selection. Callers that renderTraitsMenuContentwithout the callback are unchanged.Reviewed by Cursor Bugbot for commit 9a5f32b. Bugbot is set up for automated code reviews on this repo. Configure here.