Skip to content

fix(web): close reasoning picker after selection#4523

Open
eimexdev wants to merge 1 commit into
pingdotgg:mainfrom
eimexdev:agent/close-reasoning-picker-after-selection
Open

fix(web): close reasoning picker after selection#4523
eimexdev wants to merge 1 commit into
pingdotgg:mainfrom
eimexdev:agent/close-reasoning-picker-after-selection

Conversation

@eimexdev

@eimexdev eimexdev commented Jul 25, 2026

Copy link
Copy Markdown

Fixes #4522

What Changed

  • Close the traits picker after selecting a reasoning level.
  • Apply the same behavior to boolean and prompt-injected traits, including Ultrathink.
  • Keep the close callback optional for standalone TraitsMenuContent consumers.

Why

Selecting a reasoning level updates the value, but the controlled picker remains open. The selection handlers update the underlying state without requesting that the parent menu close.

Passing an optional close callback into the menu content keeps the change scoped to the picker while restoring the expected single-selection menu behavior.

UI Changes

Before

reasoning-picker-before.mp4

After

reasoning-picker-after.mp4

Verified in the web client with both Claude and Codex reasoning options.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Close reasoning picker menu after trait selection

The traits picker menu previously stayed open after a user selected a value. Now, TraitsMenuContent calls an optional onRequestClose callback after any selection (trait value, boolean toggle, or prompt-injected value), and TraitsPicker passes a handler that sets menu open state to false.

Macroscope summarized 9a5f32b.


Note

Low Risk
Small UI interaction fix in TraitsPicker with an optional callback; no auth, data, or persistence changes.

Overview
The traits picker menu stayed open after choosing a reasoning level or other trait. TraitsMenuContent now accepts an optional onRequestClose and invokes it after a successful select change (including Ultrathink / prompt-injected options) and after boolean On/Off picks.

TraitsPicker passes onRequestClose={() => setIsMenuOpen(false)} so the controlled menu closes on each selection. Callers that render TraitsMenuContent without the callback are unchanged.

Reviewed by Cursor Bugbot for commit 9a5f32b. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4d6da3a3-a07e-4188-876b-f4a3c8f0d7d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Jul 25, 2026
@eimexdev
eimexdev marked this pull request as ready for review July 25, 2026 15:37
@macroscopeapp

macroscopeapp Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Straightforward UI fix adding an optional onRequestClose callback to close the traits picker after selection. Self-contained change following a standard dropdown pattern with no runtime risk.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Reasoning picker remains open after selecting a reasoning level

1 participant