Skip to content

fix(web): close reasoning picker after selection #4523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eimexdev wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

fix(web): close reasoning picker after selection #4523

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion apps/web/src/components/chat/TraitsPicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,11 @@ export interface TraitsMenuContentProps {
triggerClassName?: string;
}

type TraitsMenuContentImplProps = TraitsMenuContentProps &
TraitsPersistence & {
onRequestClose?: () => void;
};

export const TraitsMenuContent = memo(function TraitsMenuContentImpl({
provider,
instanceId,
Expand All @@ -229,8 +234,9 @@ export const TraitsMenuContent = memo(function TraitsMenuContentImpl({
onPromptChange,
modelOptions,
allowPromptInjectedEffort = true,
onRequestClose,
...persistence
}: TraitsMenuContentProps & TraitsPersistence) {
}: TraitsMenuContentImplProps) {
const setProviderModelOptions = useComposerDraftStore((store) => store.setProviderModelOptions);
const updateModelOptions = useCallback(
(nextOptions: ProviderOptions | undefined) => {
Expand Down Expand Up @@ -281,6 +287,7 @@ export const TraitsMenuContent = memo(function TraitsMenuContentImpl({
? ULTRATHINK_PROMPT_PREFIX
: applyClaudePromptEffortPrefix(prompt, "ultrathink");
onPromptChange(nextPrompt);
onRequestClose?.();
return;
}
if (ultrathinkInBodyText && descriptor.id === primarySelectDescriptor?.id) return;
Expand All @@ -289,6 +296,7 @@ export const TraitsMenuContent = memo(function TraitsMenuContentImpl({
onPromptChange(stripped);
}
updateDescriptors(replaceDescriptorCurrentValue(descriptors, descriptor.id, value));
onRequestClose?.();
};

if (!hasAnyControls) {
Expand Down Expand Up @@ -361,6 +369,7 @@ export const TraitsMenuContent = memo(function TraitsMenuContentImpl({
updateDescriptors(
replaceDescriptorCurrentValue(descriptors, descriptor.id, value === "on"),
);
onRequestClose?.();
}}
>
{(["on", "off"] as const).map((value) => (
Expand Down Expand Up @@ -515,6 +524,7 @@ export const TraitsPicker = memo(function TraitsPicker({
onPromptChange={onPromptChange}
modelOptions={modelOptions}
allowPromptInjectedEffort={allowPromptInjectedEffort}
onRequestClose={() => setIsMenuOpen(false)}
{...persistence}
/>
</MenuPopup>
Expand Down
Loading