New gha ci by timcoding1988 · Pull Request #887 · podman-container-tools/container-libs

timcoding1988 · 2026-06-01T14:17:55Z

new GHA based on PR from podman-container-tools/container-libs-sandbox#1

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> Signed-off-by: Tim Zhou <timcoding1988@gmail.com>

mtrmac · 2026-06-01T14:47:12Z

+
+    GOSRC="$(pwd)"
+    SKOPEO_PATH="/var/tmp/skopeo"
+    SKOPEO_CIDEV_CONTAINER_FQIN="quay.io/libpod/skopeo_cidev:latest"


(Just a drive-by, I won’t be able to review this today.) We never used :latest — if it even exists.

right though the automation to build these is dead, we need to add a new one in https://github.com/podman-container-tools/automation for this image

Luap99

LGTM, we can tweak later, some CI is better none

inknos · 2026-06-02T14:56:28Z

+            ./hack/ci/df.log
+          if-no-files-found: ignore
+
+  common-test:


should this job use the path-filter dependency too?

common has to run always basically, I guess the only exception would be basic readme changes but not really worth making this more complicated here as tests are fast enough.

ok, so LGTM

kolyshkin · 2026-06-03T18:48:14Z

+  cancel-in-progress: true
+
+env:
+  GO_VERSION: "1.26.x"


I'd rather remove this line and use go-version-file: go.mod below with setup-go.

kolyshkin · 2026-06-03T18:48:30Z

+
+env:
+  GO_VERSION: "1.26.x"
+  LIMA_VERSION: "v2.1.1"


Latest lima is usually fine so we can drop this one, too.

kolyshkin · 2026-06-03T18:49:04Z

+
+jobs:
+  path-filter:
+    runs-on: ubuntu-24.04


nit: ubuntu-latest so we have less diff noise / maintenance burden in the future.

mtrmac

Thanks! One real gap - the c/image tests that run as root are not correctly executed.

Otherwise, just a few changes, mostly to document motivations / outstanding actions, please.

Completely ignore the “not now” comments.

mtrmac · 2026-06-02T16:06:14Z

+      - main
+      - podman-*
+  pull_request:
+    branches:


(Do we need this branch restriction? Running on everything would “fail closed”.)

mtrmac · 2026-06-02T16:09:09Z

+  cancel-in-progress: true
+
+env:
+  GO_VERSION: "1.26.x"


Hard-coding a version would mean we need to manage updates.

For linters / warnings, we can use go-version: stable and there is nothing to manage.

If we do want a precise version, we can drive it by go.mod via go-version-file.

mtrmac · 2026-06-02T16:15:49Z

+          if [[ "${{ contains(needs.*.result, 'failure') }}" == "true" ]] || \
+             [[ "${{ contains(needs.*.result, 'cancelled') }}" == "true" ]]; then


(Not now? I’d prefer this to check only for success/skipped, and fail on unexpected states.)

mtrmac · 2026-06-04T12:40:32Z

+
+source "$SCRIPT_DIR/lib.sh"
+
+AUTOMATION_RELEASE="20260520t200858z"


Is this the right place for

Suggested change

AUTOMATION_RELEASE="20260520t200858z"

AUTOMATION_RELEASE="20260520t200858z" # FIXME: Make this Renovate-managed

?

mtrmac · 2026-06-04T12:44:56Z

+    --set ".images=[{\"location\":\"$IMAGE_URL\", \"arch\": \"x86_64\"}]" \
+    "$SCRIPT_DIR/template.lima.yml"
+
+limactl copy "$REPO_DIR" "$LIMA_VM_NAME:/var/tmp/container-libs"


Not now: Is it plausible to use mounts? It’s probably not material here but to benefit from Go module / … cache, we might need to copy hundreds of megabytes of data.

I tried mounts on podman originally the problem is that I was not able to get the selinux labels right that way as they where set on the entire mount on a per file basis.

mtrmac · 2026-06-04T13:18:38Z

+
+    GOSRC="$(pwd)"
+    SKOPEO_PATH="/var/tmp/skopeo"
+    SKOPEO_CIDEV_CONTAINER_FQIN="quay.io/libpod/skopeo_cidev:latest"


If this is should be Renovate-managed, please add a FIXME comment.

mtrmac · 2026-06-04T13:21:57Z

+    sudo mkdir -p /registry
+    sudo cp -a "$mnt/atomic-registry-config.yml" /
+    sudo podman umount --latest
+    sudo podman rm --latest


Not now: Could we embed the binaries directly into the VM image?

mtrmac · 2026-06-04T13:23:04Z

+    sudo podman umount --latest
+    sudo podman rm --latest
+
+    git clone -b main https://github.com/containers/skopeo.git "$SKOPEO_PATH"


We will need to use release branches of Skopeo on stable branches of c/image.

So the main should at the very least be a top-level variable in the script (previously SKOPEO_CI_BRANCH).

mtrmac · 2026-06-04T14:05:40Z

+        paste -sd "|" -)
+    if [ -n "$test_filter" ]; then
+        sudo -E env "PATH=$PATH" "GOPATH=$GOPATH_DIR" "HOME=$HOME" \
+            make test "BUILDTAGS=$BUILDTAGS" "TESTFLAGS=-v -run $test_filter" TEST_PACKAGES=./storage


This seems to be reporting testing: warning: no tests to run, i.e. the filter computation does not work.

Added some debug logging in #891 , to hopefully speed this up.

#891 has a fix that could be ported here.

One part (missing ') is a clear bug in the CI port, that’s fine

Another part is that it seems ~impossible to prevent Make evaluating a $ in a value, so we have to pre-escape. Am I missing a clean solution? If not, this definitely needs a comment (and preserving more of the original comment about how the filter is constructed would be nice.)

If I understand the situation correctly, this never worked?! I am surprised we merged the original PR without noticing.

mtrmac · 2026-06-04T14:11:00Z

+echo
+echo "#################"
+echo "Logging system info"
+echo "#################"


Not now, https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-commands documents various formats that we probably can use to get a nicer UI (collapsible groups, group titles, default-collapsed groups)

~~Done~~ prototyped in #891 , results in much less log noise.

mheon · 2026-06-05T15:04:28Z

While there are a lot of comments on this, I will just say: having working CI is better than not having working CI, and we can work details in follow-on PRs. I suggest we just merge this now.

We need working CI

mtrmac · 2026-06-05T15:42:37Z

Thanks @timcoding1988 @giuseppe !

giuseppe added 2 commits June 1, 2026 10:12

ci: rename contrib/cirrus to hack/ci

e7a48b3

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> Signed-off-by: Tim Zhou <timcoding1988@gmail.com>

ci: replace Cirrus CI with GitHub Actions

5bf07fd

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> Signed-off-by: Tim Zhou <timcoding1988@gmail.com>

github-actions Bot added storage Related to "storage" package image Related to "image" package labels Jun 1, 2026

mtrmac reviewed Jun 1, 2026

View reviewed changes

Luap99 mentioned this pull request Jun 1, 2026

automate skopeocidev image builds podman-container-tools/automation#9

Closed

Luap99 approved these changes Jun 2, 2026

View reviewed changes

inknos reviewed Jun 2, 2026

View reviewed changes

kolyshkin reviewed Jun 3, 2026

View reviewed changes

mtrmac previously requested changes Jun 4, 2026

View reviewed changes

mtrmac mentioned this pull request Jun 4, 2026

CI improvements #891

Open

mheon approved these changes Jun 5, 2026

View reviewed changes

mheon merged commit d711236 into podman-container-tools:main Jun 5, 2026
44 of 52 checks passed

		if [[ "${{ contains(needs.*.result, 'failure') }}" == "true" ]] \|\| \
		[[ "${{ contains(needs.*.result, 'cancelled') }}" == "true" ]]; then


		source "$SCRIPT_DIR/lib.sh"

		AUTOMATION_RELEASE="20260520t200858z"

	AUTOMATION_RELEASE="20260520t200858z"
	AUTOMATION_RELEASE="20260520t200858z" # FIXME: Make this Renovate-managed

Conversation

timcoding1988 commented Jun 1, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Luap99 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mtrmac left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mtrmac Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mheon commented Jun 5, 2026

Uh oh!

Uh oh!

mtrmac commented Jun 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mtrmac Jun 4, 2026 •

edited

Loading