CI improvements#891
Open
mtrmac wants to merge 7 commits into
Open
Conversation
github-actions
Bot
added
storage
Merged
mtrmac
force-pushed
the
ci-experiment
branch
10 times, most recently
from
83e084a to
200f1ff
Compare
This makes for a much nicer web page, focusing on the actual tests. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... and note that we should have it Renovate-managed. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This should let us benefit from the latest diagnostics without having to manage a specific version. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This matches the previous situation + comment, but I don't know personally why this was done and I don't have a confirmation by the original author. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Contributor
Author
|
@timcoding1988 @podman-container-tools/container-libs-maintainers PTAL. |
Luap99
reviewed
Jun 5, 2026
| GOSRC="$(pwd)" | ||
| SKOPEO_PATH="/var/tmp/skopeo" | ||
| SKOPEO_CIDEV_CONTAINER_FQIN="quay.io/libpod/skopeo_cidev:latest" | ||
| SKOPEO_CIDEV_CONTAINER_FQIN="quay.io/libpod/skopeo_cidev:c20260425t010036z-f43f42d14" # FIXME: should be Renovate-managed |
Member
There was a problem hiding this comment.
should use our new image ghcr.io/podman-container-tools/skopeo_cidev:20260603t174659z
otherwise there is no upgrade path for the old one atm
Comment on lines
+73
to
+74
| # /tmp is a tmpfs, and as of 2025-09-11 we are using Debian images with Linux 6.1, where tmpfs does not support extended attributes. | ||
| # That prevents testing various graph drivers; so, use ext4 there. |
Member
There was a problem hiding this comment.
well the current images no longer have this so IMO just drop this section and see what happens.
Also the context is #339 then lets just switch TMPDIR instead of this?
But I think dropping this altogether is just better
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses some review comments from #887 , primarily ensuring we actually run the root-only tests in c/image/storage.
See individual commit messages for details.