Correct the implicit-key skip comments: the debug dump is unconditional, not a no-op assertion#372
Merged
Merged
Conversation
…al, not a no-op assertion The `isImplicit` skip comments described WALA's call-graph-IR dump as reached via a "no-op-assertion debug path." `Assertions.UNREACHABLE()` throws `UnimplementedError` unconditionally rather than no-opping when assertions are disabled; the dump itself is the unconditional debug print. Reword accordingly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR corrects misleading inline documentation around why the analysis skips “implicit” pointer keys in WALA propagation: the call-graph IR dump is triggered via an unconditional debug print (not a “no-op assertion” path). This is a comment-only change with no behavioral impact.
Changes:
- Reworded the implicit-key skip comment in
TensorGeneratorFactoryto accurately describe the unconditional debug output behavior. - Reworded three corresponding implicit-key skip comments in
PythonTensorAnalysisEnginefor consistency and correctness.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| com.ibm.wala.cast.python.ml/source/com/ibm/wala/cast/python/ml/client/TensorGeneratorFactory.java | Updates the implicit-key skip explanation to “unconditional debug print.” |
| com.ibm.wala.cast.python.ml/source/com/ibm/wala/cast/python/ml/client/PythonTensorAnalysisEngine.java | Aligns three implicit-key skip comments with the corrected “unconditional debug print” wording. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #372 +/- ##
=========================================
Coverage 71.67% 71.67%
Complexity 2731 2731
=========================================
Files 272 272
Lines 20347 20347
Branches 3283 3283
=========================================
Hits 14583 14583
Misses 4470 4470
Partials 1294 1294 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
isImplicitskip comments added with #371 described WALA's call-graph-IR dump as reached via a "no-op-assertion debug path." That's inaccurate:Assertions.UNREACHABLE()throwsUnimplementedErrorunconditionally (it does not no-op when assertions are disabled), and the dump itself is an unconditionalSystem.errprint. Reworded the four comments to "unconditional debug print." Comment-only; no behavior change.Surfaced by liblit in wala/WALA#1934; the same correction was applied to wala#573 and the WALA PR description.