Skip to content

Correct the implicit-key skip comments: the debug dump is unconditional, not a no-op assertion #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khatchad merged 1 commit into from
Jun 10, 2026
Merged

Correct the implicit-key skip comments: the debug dump is unconditional, not a no-op assertion #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ....cast.python.ml/source/com/ibm/wala/cast/python/ml/client/PythonTensorAnalysisEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,7 +862,7 @@ private Map<PointsToSetVariable, TensorType> getShapeSourceCalls(
.getHeapModel()
.getPointerKeyForLocal(src, call.getDef());
// Materializing an implicitly-represented key would make WALA dump the entire call
// graph's IR (a no-op-assertion debug path), so skip it; implicit keys carry no
// graph's IR (an unconditional debug print), so skip it; implicit keys carry no
// explicit dataflow variable to pin (wala/ML#573).
if (!builder.getPropagationSystem().isImplicit(defKey))
targets.put(
Expand Down Expand Up @@ -961,7 +961,7 @@ private Map<PointsToSetVariable, TensorType> getSetShapeCallsSyntactic(
}
if (!receiverEligible) continue;
// Skip implicitly-represented receivers: materializing one makes WALA dump the entire
// call graph's IR via a no-op-assertion debug path (wala/ML#573), and an implicit key has
// call graph's IR via an unconditional debug print (wala/ML#573), and an implicit key has
// no explicit dataflow variable to pin.
if (builder.getPropagationSystem().isImplicit(receiverKey)) continue;
targets.put(
Expand All @@ -982,7 +982,7 @@ private Set<PointsToSetVariable> getKeysDefinedByCall(
PointerKey defKey =
builder.getPointerAnalysis().getHeapModel().getPointerKeyForLocal(src, call.getDef());
// Skip implicitly-represented keys: materializing one makes WALA dump the entire call
// graph's IR via a no-op-assertion debug path (wala/ML#573), and an implicit key has no
// graph's IR via an unconditional debug print (wala/ML#573), and an implicit key has no
// explicit dataflow variable to track.
if (!builder.getPropagationSystem().isImplicit(defKey))
lvals.add(builder.getPropagationSystem().findOrCreatePointsToSet(defKey));
Expand Down
4 changes: 2 additions & 2 deletions ...wala.cast.python.ml/source/com/ibm/wala/cast/python/ml/client/TensorGeneratorFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,8 +424,8 @@ public static PointsToSetVariable findCreator(

private static PointsToSetVariable getPointsToSetVariable(
PointerKey key, PropagationCallGraphBuilder builder) {
// Materializing an implicitly-represented key makes WALA dump the entire call graph's IR via a
// no-op-assertion debug path (wala/ML#573); skip it (the caller treats null as "no PTS").
// Materializing an implicitly-represented key makes WALA dump the entire call graph's IR via an
// unconditional debug print (wala/ML#573); skip it (the caller treats null as "no PTS").
if (builder.getPropagationSystem().isImplicit(key)) return null;
try {
return builder.getPropagationSystem().findOrCreatePointsToSet(key);
Expand Down
Loading