Add hidden feature switch for the new Configure LLM Providers modal#14856
Open
bricestacey wants to merge 1 commit into
Open
Add hidden feature switch for the new Configure LLM Providers modal#14856bricestacey wants to merge 1 commit into
bricestacey wants to merge 1 commit into
Conversation
Gate a new provider-configuration modal behind a hidden, uncontributed setting (assistant.newProviderModal, default false). All provider-config entry points funnel through PositronAssistantService.showLanguageModelModalDialog, so the switch is read live in that single place to select between the new modal and the legacy dialog. Adds a minimal shell for the new modal; the header/footer chrome and provider flows are built out in follow-up work. See #14814
|
E2E Tests 🚀 Why these tags?
More on automatic tags from changed files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14814
Summary
Adds a hidden feature switch that selects a new "Configure LLM Providers" modal over the legacy language model provider dialog. This is the first step of a larger effort; the new modal's chrome and provider flows land in follow-ups (#14815, #14818, #14819).
The switch (
assistant.newProviderModal) is intentionally not contributed to the configuration registry, so it stays hidden from the Settings editor and defaults to the legacy dialog. All provider-configuration entry points (theConfigure Language Model Providerscommand, the Accounts menu item, and the "Configure" notification action) funnel throughPositronAssistantService.showLanguageModelModalDialog, so the switch is read live in that single place. This PR also adds a minimal shell so the switch has something to open.Release Notes
New Features
Bug Fixes
Validation Steps
@:assistant
"assistant.newProviderModal": truetosettings.json(hidden setting, won't autocomplete).