Skip to content

fix(index): extract magic numbers 50 and 30 to named constants#91

Merged
poyrazK merged 2 commits intomainfrom
fix/extract-highlight-magic-numbers
May 2, 2026
Merged

fix(index): extract magic numbers 50 and 30 to named constants#91
poyrazK merged 2 commits intomainfrom
fix/extract-highlight-magic-numbers

Conversation

@poyrazK
Copy link
Copy Markdown
Owner

@poyrazK poyrazK commented May 2, 2026

Summary

Test plan

  • cargo test --package cloudsearch-index -- highlight_positions_case_insensitive — passes
  • cargo clippy --package cloudsearch-index --all-targets — clean

Replace hardcoded context window sizes in extract_highlight() with
named constants HIGHLIGHT_PRE_CONTEXT_CHARS and HIGHLIGHT_POST_CONTEXT_CHARS
to improve readability and avoid magic numbers.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 2, 2026

Warning

Rate limit exceeded

@poyrazK has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 27 minutes and 46 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 09762969-7c4e-43cf-a2f9-20fe767c7ac7

📥 Commits

Reviewing files that changed from the base of the PR and between 9ce969a and 6488dac.

📒 Files selected for processing (1)
  • rust/crates/cloudsearch-index/src/lib.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/extract-highlight-magic-numbers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 27 minutes and 46 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Owner Author

@poyrazK poyrazK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay to merge

@poyrazK poyrazK merged commit 92ae7e7 into main May 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant