Skip to content

fix(index): extract magic numbers 50 and 30 to named constants #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
poyrazK merged 2 commits into from
May 2, 2026
+10 −4
Merged

fix(index): extract magic numbers 50 and 30 to named constants #91

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48468f5
fix(index): extract magic numbers 50 and 30 to named constants
poyrazK May 2, 2026
6488dac
style: apply rustfmt
poyrazK May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions rust/crates/cloudsearch-index/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1820,6 +1820,11 @@ fn hash_doc_id(id: &str) -> u64 {
hasher.finish()
}

/// Number of characters to include before the matched term in a highlight fragment.
const HIGHLIGHT_PRE_CONTEXT_CHARS: usize = 50;
/// Number of characters to include after the matched term in a highlight fragment.
const HIGHLIGHT_POST_CONTEXT_CHARS: usize = 30;

/// Extract highlight fragments from a document's text fields using position data.
#[allow(clippy::cast_possible_truncation)]
fn extract_highlight(
Expand Down Expand Up @@ -1856,13 +1861,14 @@ fn extract_highlight(
if pos >= text.len() {
continue;
}
// Extract window around match: 50 chars before, matched term, 30 after
let pre_start = pos.saturating_sub(50);
// Extract window around match: pre chars before, matched term, post chars after
let pre_start = pos.saturating_sub(HIGHLIGHT_PRE_CONTEXT_CHARS);
let pre = &text[pre_start..pos];
let term_match =
&text[pos..pos.saturating_add(term.len()).min(text.len())];
let post_end =
pos.saturating_add(term.len() + 30).min(text.len());
let post_end = pos
.saturating_add(term.len() + HIGHLIGHT_POST_CONTEXT_CHARS)
.min(text.len());
let post = if pos.saturating_add(term.len()) < post_end {
&text[pos.saturating_add(term.len())..post_end]
} else {
Expand Down