Skip to content

Fail HOL-Light tests on unsupported arch #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fegge wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Open

Fail HOL-Light tests on unsupported arch #1232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions scripts/tests
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1049,12 +1049,14 @@ class Tests:
self.check_fail()

def hol_light(self):
if platform.machine().lower() in ["arm64", "aarch64"]:
machine = platform.machine().lower()
if machine in ["arm64", "aarch64"]:
arch = "aarch64"
elif platform.machine().lower() in ["x86_64"]:
elif machine in ["x86_64"]:
arch = "x86_64"
else:
return
self.fail(f"HOL-Light unsupported architecture: {machine}")
self.check_fail()

@hanno-becker hanno-becker Jun 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-existing: Looking at the script, it seems that we almost always call check_fail at the end of each individual test. Why don't we just call check_fail() once at the very end of main?


def list_proofs(arch):
cmd_str = ["./proofs/hol_light/" + arch + "/list_proofs.sh"]
Expand Down
Loading