Fail HOL-Light tests on unsupported arch#1232
Open
fegge wants to merge 1 commit into
Open
Conversation
Signed-off-by: Fredrik Dahlgren <fredrik.dahlgren@trailofbits.com>
This was referenced Jun 26, 2026
Contributor
CBMC Results (ML-DSA-65, REDUCE-RAM)Full Results (205 proofs)
|
Contributor
CBMC Results (ML-DSA-87, REDUCE-RAM)Full Results (205 proofs)
|
Contributor
CBMC Results (ML-DSA-65)Full Results (205 proofs)
|
Contributor
CBMC Results (ML-DSA-44)Full Results (205 proofs)
|
Contributor
CBMC Results (ML-DSA-87)Full Results (205 proofs)
|
| else: | ||
| return | ||
| self.fail(f"HOL-Light unsupported architecture: {machine}") | ||
| self.check_fail() |
Contributor
There was a problem hiding this comment.
Pre-existing: Looking at the script, it seems that we almost always call check_fail at the end of each individual test. Why don't we just call check_fail() once at the very end of main?
hanno-becker
approved these changes
Jun 27, 2026
hanno-becker
left a comment
Contributor
There was a problem hiding this comment.
I wonder if we should take the opportunity to hoist check_fail to the bottom of the script instead invoking it in many disparate places. But this is a pre-existing issue and need not necessarily be addressed here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
ruff format scripts/tests: passedruff check scripts/tests: passedpython3 -m py_compile scripts/tests: passedgit diff --check -- scripts/tests: passedpython3 scripts/tests hol_light --list-functions: passedplatform.machine()mocked toriscv64: failed as expected withHOL-Light unsupported architecture: riscv64./scripts/formatbecausenixpkgs-fmtis not installed in this local environment./scripts/lintbecauseshfmtis not installed in this local environmentFixes #1214
This work was completed by Trail of Bits as part of the Patch The Planet project in collaboration with OpenAI. The issue was identified primarily by the Codex coding agent, and manually reviewed before submission.