NCL-9545 - Remove Alignment 2#607
Merged
rnc merged 26 commits intoproject-ncl:masterfrom Feb 26, 2026
Merged
Conversation
This reverts commit 986d878.
This reverts commit 444a436.
This reverts commit bf4d80a.
This reverts commit c300858.
This reverts commit ddc58a2.
This reverts commit 9dc6742.
…lifiers" This reverts commit cc5ae7c.
This reverts commit f4f9981.
This reverts commit ec04234.
This reverts commit 56f0d3d.
This reverts commit 897464a.
This reverts commit 372a71e.
This reverts commit 3eb562b.
…ing" This reverts commit d2cf31b.
…sions" This reverts commit 87eee82.
This reverts commit 0b48f59.
This reverts commit 20fa334.
This reverts commit 6f20793.
This reverts commit 7dc9413.
This reverts commit dd4ee72.
Contributor
Author
|
retest this please |
Contributor
|
Deferring to Jan for this one! |
michalovjan
requested changes
Feb 26, 2026
| versions.add(parts[3]); | ||
| } else { | ||
| log.error("Cannot read version for artifact with identifier {}", art.getIdentifier()); | ||
| log.error("Cannot read version for artifact with identifier %s", art.getIdentifier()); |
Contributor
There was a problem hiding this comment.
This was actually an improvement here.
Contributor
Author
There was a problem hiding this comment.
It probably got removed in the mass reverts, I can go through and reapply them.
| versions.add(parts[1]); | ||
| } else { | ||
| log.error("Cannot read version for artifact with identifier {}", art.getIdentifier()); | ||
| log.error("Cannot read version for artifact with identifier %s", art.getIdentifier()); |
Contributor
There was a problem hiding this comment.
This was actually an improvement here.
Contributor
Author
There was a problem hiding this comment.
It probably got removed in the mass reverts, I can go through and reapply them.
pom.xml
Outdated
| <version.pnc-api>2.5.0-SNAPSHOT</version.pnc-api> | ||
| <version.pnc>3.4.2</version.pnc> | ||
| <version.pnc-common>3.4.1-SNAPSHOT</version.pnc-common> | ||
| <version.pnc-api>3.5.0-SNAPSHOT</version.pnc-api> |
Contributor
There was a problem hiding this comment.
is there a particular reason for the SNAPSHOT instead of latest released version of pnc-api? same for pnc-common
Contributor
Author
There was a problem hiding this comment.
pnc-api can be fixed version I think but pnc-common needs to be snapshot to pick up the changes from dependent PR
michalovjan
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will have associated commits in pnc-common and pnc-api. While Alignment2 was removed from orch & bacon it is still in the other repositories specifically DA. Those two commits will be needed to be merged first.
I realise there is a lot of commits here - I first revert everything down to the alignment 2 and then reverted some of latest reverts to reapply them. I also had to do some tweaks for opentelemetry and httpcomponents.