Ensure facet filter gray box (in modal or facet browse page) doesn't …#3553
Ensure facet filter gray box (in modal or facet browse page) doesn't …#3553
Conversation
…appear if it's empty. Fixes #3552. - this area will be empty for facets configured with suggest: false - uses a simple :has CSS rule rather than complicate the template rendering
|
With With With With |
| /* Facet browse pages & modals | ||
| -------------------------------------------------- */ | ||
| .facet-filters:not(:has(*)) { | ||
| display: none !important; |
There was a problem hiding this comment.
Why does this have to be !important?
There was a problem hiding this comment.
Great question -- thanks for flagging that. It turns out, that is due to a related bug. The .facet-filters div is also a .card, and all .card elements get display: flex from Bootstrap CSS.
The generated application.css is currently putting the Bootstrap CSS after the Blacklight CSS (per this code), so the Bootstrap styles are taking precedence without !important.
I will create a bug ticket for that order issue, and a PR, then afterward I can rebase this PR and remove the !important.
3 participants
…appear if it's empty. Fixes #3552.