Skip to content

Comments

Php8.5 patch#2

Open
knit-pay wants to merge 4 commits intopronamic:mainfrom
knit-pay:php8.5-patch
Open

Php8.5 patch#2
knit-pay wants to merge 4 commits intopronamic:mainfrom
knit-pay:php8.5-patch

Conversation

@knit-pay
Copy link

Fixed PHP 8.5 Deprecated Code.

[23-Feb-2026 19:19:34 UTC] PHP Deprecated:  Pronamic\WordPress\DateTime\DateTimeTrait::create_from_format(): Implicitly marking parameter $timezone as nullable is deprecated, the explicit nullable type must be used instead in \pronamic\wp-datetime\src\DateTimeTrait.php on line 283
[23-Feb-2026 19:19:34 UTC] PHP Deprecated:  Pronamic\WordPress\DateTime\DateTimeInterface::create_from_format(): Implicitly marking parameter $timezone as nullable is deprecated, the explicit nullable type must be used instead in \pronamic\wp-datetime\src\DateTimeInterface.php on line 113

Fixed

PHP Deprecated:  Pronamic\WordPress\DateTime\DateTimeTrait::create_from_format(): Implicitly marking parameter $timezone as nullable is deprecated, the explicit nullable type must be used instead
Fixed

PHP Deprecated:  Pronamic\WordPress\DateTime\DateTimeInterface::create_from_format(): Implicitly marking parameter $timezone as nullable is deprecated, the explicit nullable type must be used instead
@gemini-code-assist
Copy link

Summary of Changes

Hello @knit-pay, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves deprecation warnings introduced in PHP 8.5 by updating method signatures to explicitly declare nullable DateTimeZone parameters. This ensures forward compatibility and adherence to modern PHP type hinting standards, preventing runtime warnings in environments running PHP 8.5 or newer.

Highlights

  • PHP 8.5 Deprecation Fix: Addressed PHP 8.5 deprecation warnings related to implicitly nullable DateTimeZone parameters in the create_from_format method.
  • Type Hinting Update: Explicitly marked the $timezone parameter as nullable (?\DateTimeZone) in both the DateTimeInterface and DateTimeTrait implementations of create_from_format.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/DateTimeInterface.php
    • Updated the create_from_format method signature to explicitly mark the $timezone parameter as nullable.
  • src/DateTimeTrait.php
    • Updated the create_from_format method signature to explicitly mark the $timezone parameter as nullable.
Activity
  • No review comments or activity have been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses a deprecation warning in PHP 8.5 by making the $timezone parameter explicitly nullable in the create_from_format method. The changes are accurate and focused. I've added a couple of suggestions to update the corresponding PHPDoc blocks to maintain consistency between the code and its documentation.

Update PHPDoc suggested by Gemini Code Review.
Update PHPDoc suggested by Gemini Code Review.
Copy link
Author

@knit-pay knit-pay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes suggested by Gemini Code review are done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant