Conversation
Fixed PHP Deprecated: Pronamic\WordPress\DateTime\DateTimeTrait::create_from_format(): Implicitly marking parameter $timezone as nullable is deprecated, the explicit nullable type must be used instead
Fixed PHP Deprecated: Pronamic\WordPress\DateTime\DateTimeInterface::create_from_format(): Implicitly marking parameter $timezone as nullable is deprecated, the explicit nullable type must be used instead
Summary of ChangesHello @knit-pay, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves deprecation warnings introduced in PHP 8.5 by updating method signatures to explicitly declare nullable Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a deprecation warning in PHP 8.5 by making the $timezone parameter explicitly nullable in the create_from_format method. The changes are accurate and focused. I've added a couple of suggestions to update the corresponding PHPDoc blocks to maintain consistency between the code and its documentation.
Update PHPDoc suggested by Gemini Code Review.
Update PHPDoc suggested by Gemini Code Review.
knit-pay
left a comment
There was a problem hiding this comment.
Changes suggested by Gemini Code review are done.
Fixed PHP 8.5 Deprecated Code.