Skip to content

Php8.5 patch #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
knit-pay wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Php8.5 patch #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aea0102
Update DateTimeTrait.php
knit-pay Feb 23, 2026
bdc6781
Update DateTimeInterface.php
knit-pay Feb 23, 2026
571015c
Update DateTimeInterface.php
knit-pay Feb 25, 2026
055c7d6
Update DateTimeTrait.php
knit-pay Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/DateTimeInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,10 @@ public function format_i18n( $format = null );
* @link https://www.php.net/manual/en/datetime.createfromformat.php
* @link https://www.php.net/manual/en/datetimeimmutable.createfromformat.php
*
* @param string $format Format accepted by date().
* @param string $time String representing the time.
* @param \DateTimeZone $timezone A DateTimeZone object representing the desired time zone.
* @param string $format Format accepted by date().
* @param string $time String representing the time.
* @param \DateTimeZone|null $timezone A DateTimeZone object representing the desired time zone.
* @return self|false
*/
public static function create_from_format( $format, $time, \DateTimeZone $timezone = null );
public static function create_from_format( $format, $time, ?\DateTimeZone $timezone = null );
}
8 changes: 4 additions & 4 deletions src/DateTimeTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,14 +273,14 @@ public static function createFromFormat( // phpcs:ignore WordPress.NamingConvent
*
* @since 1.0.1
*
* @param string $format Format accepted by date().
* @param string $time String representing the time.
* @param \DateTimeZone $timezone A DateTimeZone object representing the desired time zone.
* @param string $format Format accepted by date().
* @param string $time String representing the time.
* @param \DateTimeZone|null $timezone A DateTimeZone object representing the desired time zone.
*
* @return self|false
*/
#[\ReturnTypeWillChange]
public static function create_from_format( $format, $time, \DateTimeZone $timezone = null ) {
public static function create_from_format( $format, $time, ?\DateTimeZone $timezone = null ) {
/*
* In PHP 5.6 or lower it's not possible to pass in an empty (null) timezone object.
* This will result in a `DateTime::createFromFormat() expects parameter 3 to be DateTimeZone, null given` error.
Expand Down