Fix crash in ModelChain.infer_spectral_model due to incorrect method call#620
Fix crash in ModelChain.infer_spectral_model due to incorrect method call#620jgaffiot wants to merge 9 commits into
Conversation
…lmgren in the comments discussing pull request #353
| and < 1900, fix year 2050 which was returning 0. | ||
| * Fix and improve :func:`~pvlib.solarposition.hour_angle` (:issue:`598`) | ||
| * Fix error in :func:`pvlib.clearsky.detect_clearsky` (:issue:`506`) | ||
| * Fix error in :func:`pvlib.modelchain.ModelChain.infer_spectral_model` (:issue:`507`) |
There was a problem hiding this comment.
Thanks for the bug report and the PR!
It looks like this current PR builds on some work from 2017, which may explain the test failures. Could you redo the PR, first pull the current master and then apply the change to ModelChain?
There was a problem hiding this comment.
That's what (I think) I did, fetching the upstream as explained in the github doc. It's just my fork is old, but clearly the modifications are only a few lines.
When running the test locally, it appears that I have pytest v4.0.0, brand new, it may explain the problem.
Otherwise, I have to re-fork the project ?
There was a problem hiding this comment.
see #623 for existing test failures. this pr will need a new test that would fail without your fix.
|
Replaced by clean PR #629 |
3 participants
mockerobject missing. Also no test of the methodinfer_spectral_modelexist intest_modelchain.docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfile for all changes.