Skip to content

Fix crash in ModelChain.infer_spectral_model due to incorrect method call #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jgaffiot wants to merge 9 commits into from
Closed

Fix crash in ModelChain.infer_spectral_model due to incorrect method call #620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
be7e357
Fix bug in __repr__ method of ModelChain
Jul 25, 2017
b9b9b46
Homogenize the string concatenation and the __repr__ method across th…
Jul 25, 2017
bbfc87f
Upate the test of ModelChain.__repr__ thanks to the code given by who…
Jul 25, 2017
c4a94a0
Update the whatsnew/v0.4.6.rst file with the bug fix and the test upd…
Jul 25, 2017
43c681c
Merge with last upstream master
Nov 20, 2018
91b0c86
Fix incorrect method call
Nov 20, 2018
6b8049e
Restore formatting
Nov 20, 2018
682f8ee
Complete whatsnew
Nov 20, 2018
43330d1
Fix issue number (my bad)
Nov 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/sphinx/source/whatsnew/v0.6.1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ Bug fixes
and < 1900, fix year 2050 which was returning 0.
* Fix and improve :func:`~pvlib.solarposition.hour_angle` (:issue:`598`)
* Fix error in :func:`pvlib.clearsky.detect_clearsky` (:issue:`506`)
* Fix error in :func:`pvlib.modelchain.ModelChain.infer_spectral_model` (:issue:`619`)


Testing
Expand Down
2 changes: 1 addition & 1 deletion pvlib/modelchain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,7 @@ def infer_spectral_model(self):
return self.sapm_spectral_loss
elif ((('Technology' in params or
'Material' in params) and
(pvsystem._infer_cell_type() is not None)) or
(self.system._infer_cell_type() is not None)) or
'first_solar_spectral_coefficients' in params):
return self.first_solar_spectral_loss
else:
Expand Down