chore: bump approx-chol to 0.2.0#46
Open
schroedk wants to merge 2 commits into
Open
Conversation
Updates approx-chol from 0.1.0 to 0.2.0 (released upstream). The 0.2 release drops the `diag` parameter from `clique_tree_sample`, which in turn makes the local `Star::diag` field (already removed) and `Elimination::diag_elim` dead code; remove the leftover field. No public API change; the sampled Schur complement may produce slightly different fill edges under the new upstream sampler, but the wire format and Preconditioner contract are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
approx-cholfrom0.1.0→0.2.0(now published on crates.io).diagparameter fromclique_tree_sample, so the leftoverStar::diagfield and unusedElimination::diag_elimborrow are removed fromcrates/within/src/block_elim/elimination.rs.Cargo.lockalso picks up a transitive shift (tempfile'sgetrandom 0.4.2→0.3.4) from the newrand 0.10dep tree pulled in byapprox-chol 0.2.0.No public API change. The new upstream sampler may yield slightly different fill edges in the Schur complement, but the wire format and
Preconditionercontract are unchanged.Test plan
cargo test --workspacepixi run testcargo bench -p within -- --quick(sanity check that fill-edge changes don't regress fixest smoke benches)