Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ Modified LSMR is now the sole iterative solver, replacing CG and GMRES.
- **BREAKING:** `Solver::new` accepts `Option<impl Into<Vec<f64>>>` for weights; `WithinError` is `#[non_exhaustive]`.
- Free `solve()` / `solve_batch()` accept `impl Into<PreconditionerInput>` (same shapes as `Solver::new`).
- `Solver` and `Preconditioner` implement `Debug`.
- `approx-chol` bumped `0.1` → `0.2` (now published on crates.io); the new upstream sampler may produce slightly different fill edges in the Schur complement.

### Fixed

Expand Down
6 changes: 3 additions & 3 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/within/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ categories = ["mathematics", "science", "algorithms"]

[dependencies]
schwarz-precond = { version = "0.1.0", path = "../schwarz-precond", features = ["serde"] }
approx-chol = { version = "0.1.0", features = ["serde"] }
approx-chol = { version = "0.2.0", features = ["serde"] }
serde = { version = "1", features = ["derive", "rc"] }
postcard = { version = "1", features = ["use-std"] }
ndarray = "0.16"
Expand Down
7 changes: 1 addition & 6 deletions crates/within/src/block_elim/elimination.rs
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@ pub(crate) struct Star<'a> {
col_indices: &'a [u32],
/// Edge weights to each neighbor.
weights: &'a [f64],
/// `D_elim[k]` (needed by `clique_tree_sample`).
diag: f64,
}

impl Star<'_> {
Expand Down Expand Up @@ -87,7 +85,7 @@ impl SampledCliqueEmitter {
}
let seed = self.seed.wrapping_add(star.index as u64);
if self.split <= 1 {
clique_tree_sample(scratch, star.diag, seed, edges);
clique_tree_sample(scratch, seed, edges);
} else {
clique_tree_sample_multi(scratch, self.split, seed, edges);
}
Expand All @@ -107,7 +105,6 @@ pub(crate) struct Elimination<'a> {
pub(crate) n_keep: usize,
pub(crate) n_elim: usize,
pub(crate) inv_diag_elim: Vec<f64>,
pub(crate) diag_elim: &'a [f64],
pub(crate) diag_keep: &'a [f64],
pub(crate) keep_to_elim: &'a CsrBlock,
pub(crate) elim_to_keep: &'a CsrBlock,
Expand Down Expand Up @@ -156,7 +153,6 @@ impl<'a> Elimination<'a> {
n_keep,
n_elim,
inv_diag_elim,
diag_elim,
diag_keep,
keep_to_elim,
elim_to_keep,
Expand All @@ -171,7 +167,6 @@ impl<'a> Elimination<'a> {
index: k,
col_indices: &self.elim_to_keep.indices[start..end],
weights: &self.elim_to_keep.data[start..end],
diag: self.diag_elim[k],
}
}

Expand Down
Loading