Skip to content

feat: improve cmap combobox generalization and add right-click-to remove#333

Merged
tlambert03 merged 3 commits intopyapp-kit:mainfrom
tlambert03:qlementine-cmap
Mar 27, 2026
Merged

feat: improve cmap combobox generalization and add right-click-to remove#333
tlambert03 merged 3 commits intopyapp-kit:mainfrom
tlambert03:qlementine-cmap

Conversation

@tlambert03
Copy link
Copy Markdown
Member

this PR:

  1. makes QColormapComboBox compatible with QlementineStyle (without changing how it looks normally), by using more generic QStyle APIs
  2. adds a right-click-to-remove from the options... so you can easily add/remove colormaps from the options

…ComboBox

refactor: improve layout handling in QColormapLineEdit
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 52.17391% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.81%. Comparing base (60cc8cf) to head (02986b1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/superqt/cmap/_cmap_combo.py 38.88% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
- Coverage   85.24%   84.81%   -0.44%     
==========================================
  Files          49       49              
  Lines        3871     3904      +33     
==========================================
+ Hits         3300     3311      +11     
- Misses        571      593      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03 tlambert03 merged commit 3285493 into pyapp-kit:main Mar 27, 2026
29 checks passed
@tlambert03 tlambert03 deleted the qlementine-cmap branch March 27, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant