Skip to content

[3.13] gh-137920: Fix semantically relevant typo in curses.window.attron (GH-137940)#138507

Merged
encukou merged 1 commit intopython:3.13from
StanFromIreland:backport-ce70a57-3.13
Oct 7, 2025
Merged

[3.13] gh-137920: Fix semantically relevant typo in curses.window.attron (GH-137940)#138507
encukou merged 1 commit intopython:3.13from
StanFromIreland:backport-ce70a57-3.13

Conversation

@StanFromIreland
Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland commented Sep 4, 2025

@python-cla-bot
Copy link
Copy Markdown

python-cla-bot bot commented Sep 4, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@StanFromIreland
Copy link
Copy Markdown
Member Author

@vict-Yang Please see #138506 (comment)

@picnixz
Copy link
Copy Markdown
Member

picnixz commented Sep 29, 2025

Considering there hasn't been a reply since then, I would suggest you to simply remove the author from the commit, but acknowledge them normally in the commit message.

@StanFromIreland
Copy link
Copy Markdown
Member Author

I thought about replacing the email with the one they used for commits in the PR, but I worry they may not use it for some specific reason, so I'll just remove.

…dow.attron` (pythonGH-137940)

Originally authored by: vict-Yang

(cherry picked from commit ce70a57)
@StanFromIreland
Copy link
Copy Markdown
Member Author

Added:

Originally authored by: vict-Yang

To avoid the email issue.

@encukou encukou merged commit 0404ca7 into python:3.13 Oct 7, 2025
41 checks passed
@StanFromIreland StanFromIreland deleted the backport-ce70a57-3.13 branch October 7, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants