Skip to content

[ExecuTorch][WebGPU] Tests for aten.sub.Tensor broadcast#20986

Open
JCNTH wants to merge 2 commits into
gh/JCNTH/90/basefrom
gh/JCNTH/90/head
Open

[ExecuTorch][WebGPU] Tests for aten.sub.Tensor broadcast#20986
JCNTH wants to merge 2 commits into
gh/JCNTH/90/basefrom
gh/JCNTH/90/head

Conversation

@JCNTH

@JCNTH JCNTH commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Tests for aten.sub.Tensor broadcast

Adds op-test coverage for aten.sub.Tensor, stacked directly on the sub op diff (op below, tests above). test/ops/test_sub.py provides SubModule + CONFIGS (same-shape, the middle/spatial broadcast [N,C,H,W] - [N,C,1,1], and an alpha != 1 case) plus the export-delegation smoke test; test/op_tests/cases.py registers the matching numeric suite (fp64 torch golden on Dawn, mirroring _mul_suite), with alpha baked into the .pte as a construct constant.

Co-authored-with: Claude Code.

Differential Revision: D112378930

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20986

Note: Links to docs will display an error until the docs builds have been completed.

❌ 128 New Failures, 2 Pending, 2 Unrelated Failures, 1 Unclassified Failure

As of commit 80c1611 with merge base c2b273e (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

  • pull / unittest / windows / windows-job (gh) (matched win rule in flaky-rules.json)
    Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under 'C:\actions-runner\_work\executorch\executorch\test-infra\.github\actions\teardown-windows'. Did you forget to run actions/checkout before running your local action?
  • pull / unittest-editable / windows / windows-job (gh) (matched win rule in flaky-rules.json)
    Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under 'C:\actions-runner\_work\executorch\executorch\test-infra\.github\actions\teardown-windows'. Did you forget to run actions/checkout before running your local action?

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 16, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

This was referenced Jul 16, 2026
[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant