Move adeak from collaborators to developers#19
Closed
adeak wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Andras Deak <adeak@users.noreply.github.com>
Member
Author
|
Dry run is broken. Is the issue that I have to use a fork? https://github.com/pyvista/admin/actions/runs/27844960844/job/82412058365?pr=19 |
banesullivan
approved these changes
Jun 19, 2026
Member
|
Ah, yes. I have the this repo pretty locked down so it probably cannot run these checks from forks. I will merge this change. We may need to instead have issue templates for future requests like this instead so that a developer/admin can issue the PR internally. |
Member
|
Replaced with #20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't expect this to become a regular occurrence for the time being (unfortunately), but this week I reviewed two PRs and it's a bit cumbersome not to have write access (my approvals are currently homeopathic, and I can't even resolve review threads).
I'd like commit rights to make the little work I can do be more efficacious :) If in time the expected benefit of write permissions is again diminished compared to any security risk, we can kick me back out of the group.
cc @banesullivan