Micro-optimization: replace list lookup with set membership#1046
Merged
mhucka merged 3 commits intoquantumlib:mainfrom Apr 13, 2026
Merged
Micro-optimization: replace list lookup with set membership#1046mhucka merged 3 commits intoquantumlib:mainfrom
mhucka merged 3 commits intoquantumlib:mainfrom
Conversation
Use a set for `GATE_PARAMS` to achieve O(1) lookups.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the GATE_PARAMS constant in qsimcirq/qsim_circuit.py from a list to a set. The reviewer pointed out that the accompanying comment still describes the variable as a 'List', which is now inaccurate, and recommended adding a type annotation to align with the project's style guide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
qsimcirq/qsim_circuit.py, changing the listGATE_PARAMSto a set will result in O(1) lookups. Not likely to make a big difference for the small set size, but perhaps it might shave some time off when many simulations are executed.