Skip to content

Micro-optimization: replace list lookup with set membership #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhucka merged 3 commits into from
Apr 13, 2026
+3 −3
Merged

Micro-optimization: replace list lookup with set membership #1046

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85e83ba
Micro-optimization: replace list lookup with set membership
mhucka Apr 12, 2026
af120a3
Merge branch 'main' into use-set-not-list
mhucka Apr 12, 2026
213f716
Correct comment
mhucka Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions qsimcirq/qsim_circuit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@

from . import qsim

# List of parameter names that appear in valid Cirq protos.
GATE_PARAMS = [
# Set of parameter names that appear in valid Cirq protos.
GATE_PARAMS = {
Comment thread
mhucka marked this conversation as resolved.
"exponent",
"phase_exponent",
"global_shift",
Expand All @@ -29,7 +29,7 @@
"axis_phase_exponent",
"phi",
"theta",
]
}


def _translate_ControlledGate(gate: cirq.ControlledGate):
Expand Down
Loading