Fix Google Sign-In broken by Service Worker intercepting auth handler#67
Merged
Fix Google Sign-In broken by Service Worker intercepting auth handler#67
Conversation
…dler The Workbox SW navigateFallback was catching Firebase reserved /__/ routes and serving index.html instead, preventing the OAuth handler from working. - Add navigateFallbackDenylist to exclude /__/ paths from SW interception - Use signInWithPopup in dev, signInWithRedirect in prod - Extract validateAndReject helper to reduce duplication - Default login tab to Google instead of email/password - Update tests to cover redirect result handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
navigateFallbackwas intercepting Firebase reserved/__/auth/handlerroutes, redirecting them toindex.htmlinstead of letting Firebase handle OAuthnavigateFallbackDenylist: [/^\/__\//]tovite.config.jsto exclude/__/paths from SW interceptionsignInWithPopupin development andsignInWithRedirectin production for Google Sign-InvalidateAndRejecthelper to reduce code duplication in AuthProviderTest plan
/__/auth/handlerno longer redirects to/login