Open
Conversation
Signed-off-by: Sylvain Niles <sylvainniles@microsoft.com>
sylvainsf
requested a deployment
to
external-contributor-approval
GitHub Actions
Waiting
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an AI-driven pull request review workflow to the Radius repository by invoking the external sylvainsf/rivendell_council reusable workflow, intended to run automated multi-reviewer analysis on PR open/sync/reopen events.
Changes:
- Added a new GitHub Actions workflow to run Rivendell Council reviews on pull requests.
- Configured the workflow to request PR write permissions and GitHub Models read access, and to pass a model identifier to the reusable workflow.
Contributor
|
@sylvainsf I've opened a new pull request, #11433, to work on those changes. Once the pull request is ready, I'll request review from you. |
12 tasks
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Sylvain Niles <sylvainniles@microsoft.com>
sylvainsf
requested a deployment
to
external-contributor-approval
GitHub Actions
Waiting
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Sylvain Niles <sylvainniles@microsoft.com>
sylvainsf
requested a deployment
to
external-contributor-approval
GitHub Actions
Waiting
Contributor
|
@sylvainsf I've opened a new pull request, #11434, to work on those changes. Once the pull request is ready, I'll request review from you. |
12 tasks
…lures (#11434) # Description On `pull_request` events from forks, `GITHUB_TOKEN` is read-only — the `council` job requesting `pull-requests: write` would fail for external contributors. Adds a job-level guard to skip execution on fork PRs. ## Changes - **`.github/workflows/rivendell_council.yml`**: Added `if` condition to the `council` job: ```yaml if: github.event.pull_request.head.repo.full_name == github.repository ``` The job is now skipped entirely when the PR originates from a fork, avoiding token permission errors. ## Type of change - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). ## Contributor checklist - An overview of proposed schema changes is included in a linked GitHub issue. - [ ] Yes <!-- TaskRadio schema --> - [x] Not applicable <!-- TaskRadio schema --> - A design document PR is created in the [design-notes repository](https://github.com/radius-project/design-notes/), if new APIs are being introduced. - [ ] Yes <!-- TaskRadio design-pr --> - [x] Not applicable <!-- TaskRadio design-pr --> - The design document has been reviewed and approved by Radius maintainers/approvers. - [ ] Yes <!-- TaskRadio design-review --> - [x] Not applicable <!-- TaskRadio design-review --> - A PR for the [samples repository](https://github.com/radius-project/samples) is created, if existing samples are affected by the changes in this PR. - [ ] Yes <!-- TaskRadio samples-pr --> - [x] Not applicable <!-- TaskRadio samples-pr --> - A PR for the [documentation repository](https://github.com/radius-project/docs) is created, if the changes in this PR affect the documentation or any user facing updates are made. - [ ] Yes <!-- TaskRadio docs-pr --> - [x] Not applicable <!-- TaskRadio docs-pr --> - A PR for the [recipes repository](https://github.com/radius-project/recipes) is created, if existing recipes are affected by the changes in this PR. - [ ] Yes <!-- TaskRadio recipes-pr --> - [x] Not applicable <!-- TaskRadio recipes-pr --> <!-- START COPILOT CODING AGENT TIPS --> --- 💬 Send tasks to Copilot coding agent from [Slack](https://gh.io/cca-slack-docs) and [Teams](https://gh.io/cca-teams-docs) to turn conversations into code. Copilot posts an update in your thread when it's finished. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: sylvainsf <540991+sylvainsf@users.noreply.github.com>
sylvainsf
requested a deployment
to
external-contributor-approval
GitHub Actions
Waiting
Signed-off-by: Sylvain Niles <sylvainniles@microsoft.com>
sylvainsf
deployed
to
external-contributor-approval
GitHub Actions
Active
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11432 +/- ##
==========================================
- Coverage 51.24% 51.24% -0.01%
==========================================
Files 699 699
Lines 44062 44062
==========================================
- Hits 22580 22578 -2
- Misses 19326 19327 +1
- Partials 2156 2157 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Radius functional test overviewClick here to see the test run details
Test Status⌛ Building Radius and pushing container images for functional tests... |
fix to call the current version Signed-off-by: Sylvain Niles <sylvainniles@microsoft.com>
sylvainsf
requested a deployment
to
external-contributor-approval
GitHub Actions
Waiting
this adds pinned shas for all upstream actions Signed-off-by: Sylvain Niles <sylvainniles@microsoft.com>
sylvainsf
requested a deployment
to
external-contributor-approval
GitHub Actions
Waiting
valid model Signed-off-by: Sylvain Niles <sylvainniles@microsoft.com>
sylvainsf
requested a deployment
to
external-contributor-approval
GitHub Actions
Waiting
Signed-off-by: Sylvain Niles <sylvainniles@microsoft.com>
sylvainsf
requested a deployment
to
external-contributor-approval
GitHub Actions
Waiting
run Signed-off-by: Sylvain Niles <sylvainniles@microsoft.com>
run Signed-off-by: Sylvain Niles <sylvainniles@microsoft.com>
Signed-off-by: Sylvain Niles <sylvainniles@microsoft.com>
sylvainsf
requested a deployment
to
external-contributor-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Rivendell Council as an AI-powered code review workflow for pull requests. This integrates sylvainsf/rivendell_council as a reusable GitHub Actions workflow that convenes a fellowship of AI reviewers — each with a specialized domain — to evaluate every PR.
The council reviews PRs in parallel using GitHub Models via
actions/ai-inference, requiring no external API keys. Each member scores the diff on a 1–10 scale and provides concerns and suggestions. Gandalf synthesizes all reviews and delivers a final PASS/FAIL verdict as a PR comment.Council members:
Changes:
.github/workflows/council-review.ymlcalling the reusable workflowType of change
Fixes: N/A
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: