Skip to content

Guard Rivendell Council workflow against fork PR write-permission failures#11434

Merged
sylvainsf merged 2 commits intosylvainsf/rivendell-reviewfrom
copilot/sub-pr-11432-again
Mar 15, 2026
Merged

Guard Rivendell Council workflow against fork PR write-permission failures#11434
sylvainsf merged 2 commits intosylvainsf/rivendell-reviewfrom
copilot/sub-pr-11432-again

Conversation

Copy link
Contributor

Copilot AI commented Mar 15, 2026

Description

On pull_request events from forks, GITHUB_TOKEN is read-only — the council job requesting pull-requests: write would fail for external contributors. Adds a job-level guard to skip execution on fork PRs.

Changes

  • .github/workflows/rivendell_council.yml: Added if condition to the council job:
    if: github.event.pull_request.head.repo.full_name == github.repository
    The job is now skipped entirely when the PR originates from a fork, avoiding token permission errors.

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Contributor checklist

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

Co-authored-by: sylvainsf <540991+sylvainsf@users.noreply.github.com>
Copilot AI changed the title [WIP] [WIP] Address feedback from review on "Consult the council" PR Guard Rivendell Council workflow against fork PR write-permission failures Mar 15, 2026
Copilot AI requested a review from sylvainsf March 15, 2026 21:35
@sylvainsf sylvainsf marked this pull request as ready for review March 15, 2026 21:37
@sylvainsf sylvainsf requested review from a team as code owners March 15, 2026 21:37
@sylvainsf sylvainsf merged commit 607b1f4 into sylvainsf/rivendell-review Mar 15, 2026
1 check passed
@sylvainsf sylvainsf deleted the copilot/sub-pr-11432-again branch March 15, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants