Add skip-to-content link and global keyboard focus visibility#1674
Draft
simple-agent-manager[bot] wants to merge 2 commits into
Draft
Add skip-to-content link and global keyboard focus visibility#1674simple-agent-manager[bot] wants to merge 2 commits into
simple-agent-manager[bot] wants to merge 2 commits into
Conversation
Adds three targeted accessibility improvements: - Skip-to-content link (sr-only, visible on focus) for keyboard users - Global :focus-visible outline using --sam-color-focus-ring design token - id="main-content" on both mobile and desktop <main> elements Form elements retain their existing box-shadow focus styles. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



External References
N/A: This change uses existing project accessibility patterns and design tokens; no external API or library contract changed.
Codebase Impact Analysis
Changed only apps/web AppShell/accessibility files and tests: apps/web/src/components/SkipToContent.tsx, apps/web/src/components/AppShell.tsx, apps/web/src/index.css, and apps/web/tests/unit/accessibility.test.tsx. No API, auth, routing, task execution, or data model paths changed.
Documentation & Specs
N/A: This is an internal UI accessibility improvement with unit-test evidence; no public docs or specs require behavior updates.
Constitution & Risk Check
Checked no-hardcoded-values risk: styling uses existing design token --sam-color-focus-ring and does not introduce URLs, credentials, service IDs, or environment assumptions. Change is additive and non-breaking.
Summary
SkipToContentcomponent) that is screen-reader-only by default and becomes visible when focused via keyboard, linking to#main-content:focus-visibleoutline (2px solid --sam-color-focus-ring,outline-offset: 2px) for all interactive elements navigated via keyboard — form inputs are excluded since they already have custom box-shadow focus stylesid="main-content"to both mobile and desktop<main>elements inAppShellChanged Files
apps/web/src/components/SkipToContent.tsxapps/web/src/components/AppShell.tsxid="main-content"to both<main>elementsapps/web/src/index.css:focus-visibleoutline (form elements excluded)apps/web/tests/unit/accessibility.test.tsxTest plan
Local validation commands
Agent Preflight
ui-change--sam-color-focus-ringdesign token🤖 Generated with Claude Code