Add missing PHPUnit stub methods to MockedClassNameCollectingNodeVisitor#118
Merged
Merged
Conversation
samsonasik
approved these changes
Mar 16, 2026
akankov
force-pushed
the
add-phpunit-stub-methods
branch
from
10bfb78 to
226325e
Compare
akankov
force-pushed
the
add-phpunit-stub-methods
branch
from
226325e to
a5b7b23
Compare
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #119
MockedClassNameCollectingNodeVisitorrecognizescreateMockandcreatePartialMockbut misses the equivalent stub methods from PHPUnit'sTestCase:createStub()createStubForIntersectionOfInterfaces()createConfiguredStub()This means classes only referenced via these stub methods are not detected as mocked, which can lead to false positives when analyzing unused classes.
Changes
Added the three missing stub method names to the
$mockMethodNamesarray inMockedClassNameCollectingNodeVisitor.