Add missing PHPUnit stub methods to MockedClassNameCollectingNodeVisitor

composer-dependency-analyser.php

@@ -14,8 +14,12 @@
     ->ignoreErrorsOnPackage('symfony/config', [ErrorType::DEV_DEPENDENCY_IN_PROD])
     ->ignoreErrorsOnPackage('symfony/dependency-injection', [ErrorType::DEV_DEPENDENCY_IN_PROD])
 
-    // test fixture
+    // test fixtures
     ->ignoreErrorsOnPath(
         __DIR__ . '/tests/EntityClassResolver/Fixture/Anything/SomeAttributeDocument.php',
         [ErrorType::UNKNOWN_CLASS]
+    )
+    ->ignoreErrorsOnPath(
+        __DIR__ . '/tests/PhpParser/NodeVisitor/MockedClassNameCollectingNodeVisitor/Fixture',
+        [ErrorType::UNKNOWN_CLASS]
     );

composer.json

@@ -14,7 +14,7 @@
         "symfony/console": "^6.4.24",
         "symfony/finder": "^7.4",
         "symfony/yaml": "^7.4",
-        "webmozart/assert": "^1.12"
+        "webmozart/assert": "^2.1"
     },
     "require-dev": {
         "symplify/easy-coding-standard": "^13.0",

src/Command/GenerateSymfonyConfigBuildersCommand.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Rector\SwissKnife\Command;
 
 use Entropy\Console\Contract\CommandInterface;
@@ -17,7 +19,7 @@
 /**
  * @see https://github.com/nelmio/alice/blob/v2.3.0/doc/complete-reference.md#php
  */
-final class GenerateSymfonyConfigBuildersCommand implements CommandInterface
+final readonly class GenerateSymfonyConfigBuildersCommand implements CommandInterface
 {
     /**
      * @var string[]
@@ -34,7 +36,7 @@ final class GenerateSymfonyConfigBuildersCommand implements CommandInterface
     ];
 
     public function __construct(
-        private readonly SymfonyStyle $symfonyStyle,
+        private SymfonyStyle $symfonyStyle,
     ) {
     }
 

src/PhpParser/NodeVisitor/MockedClassNameCollectingNodeVisitor.php

@@ -40,6 +40,9 @@ public function enterNode(Node $node): ?Node
             'mock', // https://github.com/mockery/mockery/blob/73a9714716f87510a7c2add9931884188e657541/library/Mockery.php#L475, https://github.com/laravel/framework/blob/4ca4a16772b2e89233b3606badefae34003e1538/src/Illuminate/Foundation/Testing/Concerns/InteractsWithContainer.php#L69
             'partialMock', // https://github.com/laravel/framework/blob/4ca4a16772b2e89233b3606badefae34003e1538/src/Illuminate/Foundation/Testing/Concerns/InteractsWithContainer.php#L81
             'spy', // https://github.com/mockery/mockery/blob/73a9714716f87510a7c2add9931884188e657541/library/Mockery.php#L675, https://github.com/laravel/framework/blob/4ca4a16772b2e89233b3606badefae34003e1538/src/Illuminate/Foundation/Testing/Concerns/InteractsWithContainer.php#L93
+            'createStub', // https://github.com/sebastianbergmann/phpunit/blob/d72b735d34bbff2065cef80653cafbe31cb45ba0/src/Framework/TestCase.php#L2262
+            'createStubForIntersectionOfInterfaces', // https://github.com/sebastianbergmann/phpunit/blob/d72b735d34bbff2065cef80653cafbe31cb45ba0/src/Framework/TestCase.php#L2285
+            'createConfiguredStub', // https://github.com/sebastianbergmann/phpunit/blob/d72b735d34bbff2065cef80653cafbe31cb45ba0/src/Framework/TestCase.php#2312
         ];
         if (! in_array($methodName, $mockMethodNames, true)) {
             return null;

tests/PhpParser/NodeVisitor/MockedClassNameCollectingNodeVisitor/Fixture/CreateConfiguredStubCall.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\SwissKnife\Tests\PhpParser\NodeVisitor\MockedClassNameCollectingNodeVisitor\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class CreateConfiguredStubCall extends TestCase
+{
+    public function test(): void
+    {
+        $stub = $this->createConfiguredStub(\SomeNamespace\SomeConfiguredStubClass::class, []);
+    }
+}

tests/PhpParser/NodeVisitor/MockedClassNameCollectingNodeVisitor/Fixture/CreateMockCall.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\SwissKnife\Tests\PhpParser\NodeVisitor\MockedClassNameCollectingNodeVisitor\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class CreateMockCall extends TestCase
+{
+    public function test(): void
+    {
+        $mock = $this->createMock(\SomeNamespace\SomeMockedClass::class);
+    }
+}

tests/PhpParser/NodeVisitor/MockedClassNameCollectingNodeVisitor/Fixture/CreateStubCall.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\SwissKnife\Tests\PhpParser\NodeVisitor\MockedClassNameCollectingNodeVisitor\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class CreateStubCall extends TestCase
+{
+    public function test(): void
+    {
+        $stub = $this->createStub(\SomeNamespace\SomeStubClass::class);
+    }
+}

tests/PhpParser/NodeVisitor/MockedClassNameCollectingNodeVisitor/Fixture/CreateStubForIntersectionCall.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\SwissKnife\Tests\PhpParser\NodeVisitor\MockedClassNameCollectingNodeVisitor\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class CreateStubForIntersectionCall extends TestCase
+{
+    public function test(): void
+    {
+        $stub = $this->createStubForIntersectionOfInterfaces(\SomeNamespace\SomeIntersectionClass::class);
+    }
+}

tests/PhpParser/NodeVisitor/MockedClassNameCollectingNodeVisitor/Fixture/UnrelatedMethodCall.php

@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\SwissKnife\Tests\PhpParser\NodeVisitor\MockedClassNameCollectingNodeVisitor\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class UnrelatedMethodCall extends TestCase
+{
+    public function test(): void
+    {
+        $this->assertTrue(true);
+        $this->someRandomMethod(\SomeNamespace\ShouldNotBeDetected::class);
+    }
+}

tests/PhpParser/NodeVisitor/MockedClassNameCollectingNodeVisitor/MockedClassNameCollectingNodeVisitorTest.php

@@ -0,0 +1,57 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\SwissKnife\Tests\PhpParser\NodeVisitor\MockedClassNameCollectingNodeVisitor;
+
+use Iterator;
+use PhpParser\NodeTraverser;
+use PhpParser\ParserFactory;
+use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\TestCase;
+use Rector\SwissKnife\PhpParser\NodeVisitor\MockedClassNameCollectingNodeVisitor;
+
+final class MockedClassNameCollectingNodeVisitorTest extends TestCase
+{
+    /**
+     * @param string[] $expectedClassNames
+     */
+    #[DataProvider('provideData')]
+    public function test(string $filePath, array $expectedClassNames): void
+    {
+        $mockedClassNameCollectingNodeVisitor = new MockedClassNameCollectingNodeVisitor();
+
+        $nodeTraverser = new NodeTraverser();
+        $nodeTraverser->addVisitor($mockedClassNameCollectingNodeVisitor);
+
+        $parser = (new ParserFactory())->createForNewestSupportedVersion();
+        $stmts = $parser->parse((string) file_get_contents($filePath));
+        $this->assertNotNull($stmts);
+
+        $nodeTraverser->traverse($stmts);
+
+        $this->assertSame($expectedClassNames, $mockedClassNameCollectingNodeVisitor->getMockedClassNames());
+    }
+
+    /**
+     * @return Iterator<string, array{string, string[]}>
+     */
+    public static function provideData(): Iterator
+    {
+        yield 'createMock' => [__DIR__ . '/Fixture/CreateMockCall.php', ['SomeNamespace\SomeMockedClass']];
+
+        yield 'createStub' => [__DIR__ . '/Fixture/CreateStubCall.php', ['SomeNamespace\SomeStubClass']];
+
+        yield 'createStubForIntersectionOfInterfaces' => [
+            __DIR__ . '/Fixture/CreateStubForIntersectionCall.php',
+            ['SomeNamespace\SomeIntersectionClass'],
+        ];
+
+        yield 'createConfiguredStub' => [
+            __DIR__ . '/Fixture/CreateConfiguredStubCall.php',
+            ['SomeNamespace\SomeConfiguredStubClass'],
+        ];
+
+        yield 'unrelated method is not detected' => [__DIR__ . '/Fixture/UnrelatedMethodCall.php', []];
+    }
+}