Skip to content

[rhoai-2.25] RHAIENG-6036: waive codeserver sandbox-runtime seccomp in check-payload#2500

Open
jiridanek wants to merge 1 commit into
rhoai-2.25from
fix/rhoai-2.25-codeserver-fips-waivers
Open

[rhoai-2.25] RHAIENG-6036: waive codeserver sandbox-runtime seccomp in check-payload#2500
jiridanek wants to merge 1 commit into
rhoai-2.25from
fix/rhoai-2.25-codeserver-fips-waivers

Conversation

@jiridanek

@jiridanek jiridanek commented Jul 10, 2026

Copy link
Copy Markdown
Member

Summary

Split from #2487/#2488: add check-payload FIPS waivers for @anthropic-ai/sandbox-runtime apply-seccomp static binaries on codeserver images.

Test plan

  • codeserver-ubi9-python-3.12 check-payload green on Build Notebooks matrix

Related

Made with Cursor

Summary by CodeRabbit

  • Bug Fixes
    • Updated package validation to correctly recognize additional static sandbox helper binaries.
    • Prevented false-positive crypto compliance warnings for code-server RPM packages containing these binaries.

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 01a87a4c-8791-4103-a1bd-34d1468a731b

📥 Commits

Reviewing files that changed from the base of the PR and between 08f4fe3 and e8d4179.

📒 Files selected for processing (1)
  • scripts/check-payload/config.toml

📝 Walkthrough

Walkthrough

Expanded payload checker ignore lists to include additional static apply-seccomp helper binaries from @anthropic-ai/sandbox-runtime for generic checks and code-server RPM payloads.

Changes

Payload checks

Layer / File(s) Summary
Seccomp helper ignore lists
scripts/check-payload/config.toml
Adds arm64 and x64 apply-seccomp helper paths to both relevant ErrNotDynLinked ignore lists.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is specific and matches the main change: adding check-payload waivers for codeserver sandbox-runtime seccomp binaries.
Description check ✅ Passed The description covers the summary, test plan, and related issues, but it omits the template's checklist and merge-criteria details.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/rhoai-2.25-codeserver-fips-waivers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andyatmiami for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek

Copy link
Copy Markdown
Member Author

we should not ignore this, even though we're not FIPS compliant, actually getting those exceptions is more work than taking care of this in some other way

@jiridanek

Copy link
Copy Markdown
Member Author

/hold for the reasons aboe

…runtime seccomp binaries

check-payload flags @anthropic-ai/sandbox-runtime apply-seccomp helpers as
ErrForbidden and ErrNotDynLinked on codeserver images; add FIPS waivers.

Co-authored-by: Cursor <cursoragent@cursor.com>
@jiridanek
jiridanek force-pushed the fix/rhoai-2.25-codeserver-fips-waivers branch from 3bc5a07 to e8d4179 Compare July 12, 2026 15:10
@jiridanek

Copy link
Copy Markdown
Member Author

/build-konflux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant