[rhoai-2.25] RHAIENG-6036: waive codeserver sandbox-runtime seccomp in check-payload#2500
[rhoai-2.25] RHAIENG-6036: waive codeserver sandbox-runtime seccomp in check-payload#2500jiridanek wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughExpanded payload checker ignore lists to include additional static ChangesPayload checks
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
we should not ignore this, even though we're not FIPS compliant, actually getting those exceptions is more work than taking care of this in some other way |
|
/hold for the reasons aboe |
…runtime seccomp binaries check-payload flags @anthropic-ai/sandbox-runtime apply-seccomp helpers as ErrForbidden and ErrNotDynLinked on codeserver images; add FIPS waivers. Co-authored-by: Cursor <cursoragent@cursor.com>
3bc5a07 to
e8d4179
Compare
|
/build-konflux |
Summary
Split from #2487/#2488: add check-payload FIPS waivers for
@anthropic-ai/sandbox-runtimeapply-seccompstatic binaries on codeserver images.Test plan
codeserver-ubi9-python-3.12check-payload green on Build Notebooks matrixRelated
Made with Cursor
Summary by CodeRabbit