[rhoai-2.25] fix(ppc64le): openblas-devel for ONNX numpy builds#2534
[rhoai-2.25] fix(ppc64le): openblas-devel for ONNX numpy builds#2534jiridanek wants to merge 1 commit into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughChangesThe four UBI9 Python 3.12 ONNX ppc64le build prerequisites
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.8)jupyter/datascience/ubi9-python-3.12/Dockerfile.cpuTraceback (most recent call last): jupyter/datascience/ubi9-python-3.12/Dockerfile.konflux.cpuTraceback (most recent call last): runtimes/datascience/ubi9-python-3.12/Dockerfile.cpuTraceback (most recent call last):
Comment |
|
/build-konflux |
1 similar comment
|
/build-konflux |
622ceb8 to
76a32de
Compare
ce66185 to
94f1b11
Compare
36c7a55 to
cba986d
Compare
94f1b11 to
2e75603
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/build-konflux |
requirements-min.txt pins numpy==1.26.0, which has no ppc64le wheel on PyPI, so pip builds from sdist and needs BLAS headers. Install openblas-devel in onnx-builder before pip install (jupyter + runtime). Co-authored-by: Cursor <cursoragent@cursor.com>
2e75603 to
bf30be0
Compare
|
/build-konflux |
Description
Konflux ppc64le builds of jupyter/runtime datascience fail in
onnx-builderwhen installing ONNXrequirements-min.txt:numpy==1.26.0has no ppc64le wheel on PyPI, so pip builds from sdist and needs BLAS.openblas-builderartifacts are only copied into the final image, not intoonnx-builder.This PR installs
openblas-develvia dnf inonnx-builderbeforepip install -r requirements-min.txt(verified available on UBI 9.6 ppc64le fromubi-9-codeready-builder-rpms).Depends on / follows #2519 (merged) — pylock-driven ONNX 1.22 +
requirements-min.txt. Rebased ontorhoai-2.25after that merge.Touches:
jupyter/datascience/ubi9-python-3.12/Dockerfile.cpujupyter/datascience/ubi9-python-3.12/Dockerfile.konflux.cpuruntimes/datascience/ubi9-python-3.12/Dockerfile.cpuruntimes/datascience/ubi9-python-3.12/Dockerfile.konflux.cpuHow Has This Been Tested?
podman --platform linux/ppc64le):dnf install -y openblas-develsucceeds on UBI 9.6;pip install numpy==1.26.0then builds alinux_ppc64lewheel successfully (~15m under qemu).numpy==1.26.0ppc64le wheels.Self checklist:
Dockerfile.konflux.*for rhoai-2.25Test plan
onnx-builderpasses numpy installonnx-builderpasses numpy installSummary by CodeRabbit