Revert removal of SearchUIGrandCompanies::NONE special-casing#439
Merged
Conversation
It *needs* to be special-cased, or PacketAnalyzer will display an erroneous result!
redstrate
approved these changes
Jun 12, 2026
redstrate
left a comment
redstrate
left a comment
Owner
There was a problem hiding this comment.
I still find the logic confusing but we at least shouldn't break it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It needs to be special-cased because NONE in this enum/packet is 255, not 0, or PacketAnalyzer will display an erroneous result!
It now incorrectly displays
grand_company: MAELSTROM | ADDERS | FLAMES | NONE. When it's NONE, it should displaygrand_company: NONE. I'm aware bitflags isn't exactly equipped for that, which is why I special-cased it.