Skip to content

Revert removal of SearchUIGrandCompanies::NONE special-casing #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redstrate merged 2 commits into from
Jun 12, 2026
Merged

Revert removal of SearchUIGrandCompanies::NONE special-casing #439

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c820e08
Revert removal of SearchUIGrandCompanies::NONE special-casing
thedax Jun 12, 2026
80b776d
Add comment clarifying why removing this is incorrect
thedax Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core/src/ipc/zone/search_info.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,12 @@ bitflags! {

impl std::fmt::Debug for SearchUIGrandCompanies {
fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
// Special-case NONE because it's 255 and indicates the *absence* of the flags!
// NOTE: before considering removal of this, please read the above comment!
if *self == SearchUIGrandCompanies::NONE {
return write!(f, "NONE");
}

bitflags::parser::to_writer(self, f)
}
}
Expand Down
Loading