Skip to content
This repository was archived by the owner on May 2, 2024. It is now read-only.

Move remaining troubleshoot templates to troubleshoot directory#80

Open
danj-replicated wants to merge 5 commits into
mainfrom
danj/move-analyzers
Open

Move remaining troubleshoot templates to troubleshoot directory#80
danj-replicated wants to merge 5 commits into
mainfrom
danj/move-analyzers

Conversation

@danj-replicated

Copy link
Copy Markdown
Contributor

No description provided.

@chris-sanders

chris-sanders commented May 19, 2023

Copy link
Copy Markdown
Contributor

I like this from an organization standpoint, I'm just curious how we're defining what goes in the subfolder.
Should we move all troubleshoot templates into the subfolder?

I kind of like that as a concept, all K8s objects are in lib and anything extra is added in subfolders?
I'd like to propose we do that, and you can expand this PR to move all of the troubleshoot .tpl files into the subfolder. Trying to understand how the templates work, with them split between lib and lib/troubleshoot seems like it will be hard for people.

@danj-replicated danj-replicated changed the title Move analyzer templates to troubleshoot directory Move remaining troubleshoot templates to troubleshoot directory May 19, 2023

@chris-sanders chris-sanders left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good let's just do all the templates related to troubleshoot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants