Eliminate app hang from synchronous file open#589
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an app hang (REPOPROMPT-9D) that occurred for at least 2000 ms when opening files via
NSWorkspace.shared.open().Root Cause:
The
FileViewModel.openInDefaultApp()method, and a fallback path inWorkspaceFilesViewModel.openFileForMarkdownLink(), were calling the synchronousNSWorkspace.shared.open(fileURL)on the main thread. This call blocks on a LaunchServices XPC round-trip, causing the UI to freeze.Solution:
Replaced both instances of the synchronous
NSWorkspace.shared.open(fileURL)with its asynchronous counterpart:NSWorkspace.shared.open(fileURL, configuration: NSWorkspace.OpenConfiguration(), completionHandler:). Error logging is now handled within the completion handler, preventing the main thread from blocking.Impact of changes:
openFileForMarkdownLinkmethod now always returnstrueafter dispatching the async open, as its boolean return value was previously discarded by callers (_ =), making the change in semantics practically inconsequential.Fixes REPOPROMPT-9D