Skip to content

Eliminate app hang from synchronous file open #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −4
Open

Eliminate app hang from synchronous file open #589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Sources/RepoPrompt/Features/WorkspaceFiles/ViewModels/FileViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1079,9 +1079,11 @@ class FileViewModel: ObservableObject, Identifiable, FileSystemItemViewModel, Eq

func openInDefaultApp() {
let fileURL = URL(fileURLWithPath: standardizedFullPath)
let opened = NSWorkspace.shared.open(fileURL)
if !opened {
print("Unable to open file: \(standardizedFullPath)")
let configuration = NSWorkspace.OpenConfiguration()
NSWorkspace.shared.open(fileURL, configuration: configuration) { _, error in
if let error {
print("Unable to open file: \(self.standardizedFullPath): \(error)")
}
}
}

Expand Down
8 changes: 7 additions & 1 deletion Sources/RepoPrompt/Features/WorkspaceFiles/ViewModels/WorkspaceFilesViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11751,7 +11751,13 @@ extension WorkspaceFilesViewModel {
guard standardizedPath.hasPrefix("/") else { return false }

let fileURL = URL(fileURLWithPath: standardizedPath)
return NSWorkspace.shared.open(fileURL)
let configuration = NSWorkspace.OpenConfiguration()
NSWorkspace.shared.open(fileURL, configuration: configuration) { _, error in
if let error {
print("Unable to open file: \(standardizedPath): \(error)")
}
}
return true
}

@MainActor
Expand Down
Loading