Build with OCaml 5.1.0#5895
Merged
Merged
Conversation
cknitt
force-pushed
the
ocaml-5
branch
2 times, most recently
from
a563b62 to
4257bb4
Compare
cknitt
force-pushed
the
ocaml-5
branch
6 times, most recently
from
2b5c1c6 to
ff46f38
Compare
cristianoc
reviewed
Feb 3, 2024
cristianoc
approved these changes
Feb 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build the master branch / v12 with OCaml 5.1.0.
Binaries are a bit bigger than those built with 4.14. And I haven't compared the performance.
Nonetheless, I think it would be good to have this active for v12 development. In case we discover any issues, we can still fall back to 4.14 before the v12 release.
Also, I had to deactivate reanalyze for now as there is no 5.x-compatible version of it on opam yet.