Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
runs-on: ${{matrix.os}}

container:
image: ghcr.io/rescript-lang/rescript-ci-build:alpine-3.19-ocaml-4.14.1-02
image: ghcr.io/rescript-lang/rescript-ci-build:alpine-3.19-ocaml-5.1.0-01

steps:
# See https://github.com/actions/runner/issues/801#issuecomment-1374967227.
Expand Down Expand Up @@ -115,7 +115,7 @@ jobs:
ubuntu-latest,
windows-latest,
]
ocaml_compiler: [4.14.1]
ocaml_compiler: [5.1.0]

runs-on: ${{matrix.os}}

Expand Down Expand Up @@ -158,11 +158,12 @@ jobs:
uses: ocaml/setup-ocaml@v2
if: matrix.os == 'windows-latest'
with:
ocaml-compiler: ${{matrix.ocaml_compiler}}
ocaml-compiler: ocaml-variants.5.1.0+options,ocaml-option-mingw
opam-pin: false
opam-depext: false
opam-repositories: |
opam-repository-mingw: https://github.com/ocaml-opam/opam-repository-mingw.git#sunset
windows-5.0: https://github.com/dra27/opam-repository.git#windows-5.0
sunset: https://github.com/ocaml-opam/opam-repository-mingw.git#sunset
default: https://github.com/ocaml/opam-repository.git

- name: "Install OPAM dependencies"
Expand Down Expand Up @@ -238,7 +239,7 @@ jobs:
# Build the playground compiler on the fastest runner (ubuntu-latest)
- name: Install JSOO
if: matrix.os == 'ubuntu-latest'
run: opam install js_of_ocaml.4.0.0
run: opam install js_of_ocaml.5.6.0

- name: Build playground compiler
if: matrix.os == 'ubuntu-latest'
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@ test: lib

test-syntax:
bash ./scripts/test_syntax.sh
make reanalyze
# make reanalyze
Comment thread
cknitt marked this conversation as resolved.
bash ./scripts/testok.sh

test-syntax-roundtrip:
ROUNDTRIP_TEST=1 bash ./scripts/test_syntax.sh
make reanalyze
# make reanalyze
bash ./scripts/testok.sh

test-gentype:
Expand Down
9 changes: 5 additions & 4 deletions dune-project
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@
(cppo
(= 1.6.9))
(js_of_ocaml-compiler
(= 4.0.0))
(= 5.6.0))
(ounit2
(= 2.2.6))
(reanalyze
(= 2.23.0))
(= 2.2.7))
; No OCaml 5 compatible reanalyze on OPAM yet
; (reanalyze
; (= 2.23.0))
dune))
2 changes: 1 addition & 1 deletion jscomp/frontend/bs_ast_mapper.ml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
*)

open! Parsetree
open Ast_helper
open! Ast_helper
open Location

type mapper = {
Expand Down
2 changes: 1 addition & 1 deletion jscomp/syntax/src/jsx_v4.ml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
open Ast_helper
open! Ast_helper
open Ast_mapper
open Asttypes
open Parsetree
Expand Down
5 changes: 2 additions & 3 deletions rescript.opam
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,8 @@ depends: [
"ocaml" {>= "4.10"}
"ocamlformat" {= "0.26.1"}
"cppo" {= "1.6.9"}
"js_of_ocaml-compiler" {= "4.0.0"}
"ounit2" {= "2.2.6"}
"reanalyze" {= "2.23.0"}
"js_of_ocaml-compiler" {= "5.6.0"}
"ounit2" {= "2.2.7"}
"dune"
]
build: [
Expand Down