Fix issue with generating async functions inside loops.#6479
Merged
Conversation
cc079c5 to
4cf99e5
Compare
This was referenced Nov 8, 2023
Collaborator
Author
zth
approved these changes
Nov 8, 2023
zth
left a comment
Member
There was a problem hiding this comment.
Nothing I can think of OTOH. Landing let support is going to be great, so we can get rid of these things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6444
The example comes from a code transformation that deals with closures inside loops. Specifically, since
varis function scope, and immediately-executed function is generated to capture the variable.The generated code was missing an
asyncin the returned function, but also anawaiton the outside.Note this entire transformation becomes unnecessary after #6102