Conversation
|
You can then remove the previous fix (using IIFE) used to capture mutable variable |
The scope of `var` is per-function, requiring a transformation for closures inside loops when capturing loop variables. This PR turns off the transformation. This PR should go after #6102
|
I wonder how much it'll affect performance. But probably it won't be a big difference. |
|
@DZakh did you see this: #856 (comment) ? |
|
Wow, cool |
The scope of `var` is per-function, requiring a transformation for closures inside loops when capturing loop variables. This PR turns off the transformation. This PR should go after #6102
|
@cristianoc Could you rebase this? Now that 11.1 is out and development focus is shifting to v12, it would be great to get this merged. |
cristianoc
force-pushed
the
let
branch
2 times, most recently
from
d9a369b to
698fbf5
Compare
cknitt
left a comment
cknitt
left a comment
There was a problem hiding this comment.
Thanks a lot!
Let's remove "Test" from the commit message and PR title before merging though.
|
Sorry, I'm afraid you'll also need to rebase again. |
cristianoc
changed the title
let instead of var.
cristianoc
changed the title
let instead of var.let instead of var.
|
@cknitt ready to go |
The scope of `var` is per-function, requiring a transformation for closures inside loops when capturing loop variables. This PR turns off the transformation. This PR should go after #6102
|
Just want to make a quick note that this is improvement is a requirement for the React Compiler it seems to analyze the rules of React. Changing |
6 participants
Fixes #856
Need to check that no cases are missed where this could introduce regressions even if the tests appear to be passing
This will generate a huge amount of noise in the diff w.r.t. other versions of the compiler. It might not be ideal to have this change in an initial version of compiler v11 if other changes are important as they would get lost in the noise
Note that the transformation creating problems in Fix issue with generating async functions inside loops. #6479 can be removed