feat: migrate proxy sidecar injection and add Deployment proxy reconc…#5
feat: migrate proxy sidecar injection and add Deployment proxy reconc…#5Vaishnav88sk wants to merge 4 commits into
Conversation
…iler Signed-off-by: Vaishnav88sk <vaishnavsk8804@gmail.com>
Signed-off-by: Vaishnav88sk <vaishnavsk8804@gmail.com>
Signed-off-by: Vaishnav88sk <vaishnavsk8804@gmail.com>
7275ca9 to
b7cac9e
Compare
lbroudoux
left a comment
There was a problem hiding this comment.
It looks great! Thanks @Vaishnav88sk for pushing this one. I have only one comment on the default namespace, though. Can you check that one?
Signed-off-by: Vaishnav88sk <vaishnavsk8804@gmail.com>
|
@lbroudoux updated the files. I think it is good to go. 👍🏻 |
lbroudoux
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
One thing I'm not 100% sure of at the moment is the location of the DeploymentProxyProcessor. Sure: it's an operator but I wonder if it wouldn't make more sense to integrate it within the admission part so that it will be shipped within the same container image. I had in mind that operator was much more dedicated to the lifecycle of the CR to be used by a regular user...
What do you think?
|
I originally placed it in the Quick question: Moving it means we'll need to add the |
Yes you're right.
Yes, I think we already have part of the operator-sdk as dependencies. We can manage that in the future. Let's close this PR and associated issue for now and make some progress on the reconciliers. |
This PR migrates the Kubernetes admission controller logic for injecting the Reshapr proxy sidecar from the
reshaprrepository toreshapr-controllers, fulfilling the architectural requirements outlined by maintainers.Fixes #4
I would like to hear your thoughts on this. I have made chnages according my understandings. If any chnages, please let me know!