Skip to content

feat: migrate proxy sidecar injection and add Deployment proxy reconc…#5

Closed
Vaishnav88sk wants to merge 4 commits into
reshaprio:mainfrom
Vaishnav88sk:feature/proxy-sidecar-injection
Closed

feat: migrate proxy sidecar injection and add Deployment proxy reconc…#5
Vaishnav88sk wants to merge 4 commits into
reshaprio:mainfrom
Vaishnav88sk:feature/proxy-sidecar-injection

Conversation

@Vaishnav88sk

Copy link
Copy Markdown

This PR migrates the Kubernetes admission controller logic for injecting the Reshapr proxy sidecar from the reshapr repository to reshapr-controllers, fulfilling the architectural requirements outlined by maintainers.

Fixes #4

I would like to hear your thoughts on this. I have made chnages according my understandings. If any chnages, please let me know!

@Vaishnav88sk Vaishnav88sk requested a review from lbroudoux as a code owner May 26, 2026 11:55
…iler

Signed-off-by: Vaishnav88sk <vaishnavsk8804@gmail.com>
Signed-off-by: Vaishnav88sk <vaishnavsk8804@gmail.com>
Signed-off-by: Vaishnav88sk <vaishnavsk8804@gmail.com>

@lbroudoux lbroudoux left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great! Thanks @Vaishnav88sk for pushing this one. I have only one comment on the default namespace, though. Can you check that one?

Comment thread admission/src/main/java/io/reshapr/kubernetes/admission/AdmissionControllers.java Outdated
Comment thread admission/src/main/java/io/reshapr/kubernetes/admission/AdmissionControllers.java Outdated
@lbroudoux lbroudoux added enhancement New feature or request theme/injector java Pull requests that update java code labels Jun 8, 2026
@lbroudoux lbroudoux added this to the 0.0.1 milestone Jun 8, 2026
Signed-off-by: Vaishnav88sk <vaishnavsk8804@gmail.com>
@Vaishnav88sk

Vaishnav88sk commented Jun 8, 2026

Copy link
Copy Markdown
Author

@lbroudoux updated the files. I think it is good to go. 👍🏻

@Vaishnav88sk Vaishnav88sk requested a review from lbroudoux June 8, 2026 20:47

@lbroudoux lbroudoux left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
One thing I'm not 100% sure of at the moment is the location of the DeploymentProxyProcessor. Sure: it's an operator but I wonder if it wouldn't make more sense to integrate it within the admission part so that it will be shipped within the same container image. I had in mind that operator was much more dedicated to the lifecycle of the CR to be used by a regular user...
What do you think?

@Vaishnav88sk

Copy link
Copy Markdown
Author

I originally placed it in the operator module because it uses the Reconciler pattern, but I totally agree that shipping the sidecar feature in a single container makes perfect sense.

Quick question: Moving it means we'll need to add the quarkus-operator-sdk dependency to the admission module. Are you okay with the admission module taking on that dependency?"

@Vaishnav88sk Vaishnav88sk requested a review from lbroudoux June 9, 2026 12:58
@lbroudoux

Copy link
Copy Markdown
Member

Quick question: Moving it means we'll need to add the quarkus-operator-sdk dependency to the admission module.

Yes you're right.

Are you okay with the admission module taking on that dependency?"

Yes, I think we already have part of the operator-sdk as dependencies.

We can manage that in the future. Let's close this PR and associated issue for now and make some progress on the reconciliers.

@lbroudoux lbroudoux closed this Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request java Pull requests that update java code theme/injector

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migration of Kubernetes Admission Controller for Proxy Sidecar Injection

2 participants