chore(security): redact sensitive auth logs and tighten credential file permissions#2
Open
danielecirio wants to merge 1 commit into
Open
chore(security): redact sensitive auth logs and tighten credential file permissions#2danielecirio wants to merge 1 commit into
danielecirio wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
savePkceandsaveSidwith logs that only include non-sensitive metadata (organizationDomain) insdk/src/utils/lruCache.ts.codeVerifierand token values from the OAuth callback error log and report presence using booleans (hasRefreshToken,hasAccessToken,hasCodeVerifier) insdk/src/auth/callbackHandler.ts.sdk/src/auth/sidExchange.tsand make the auth middleware message neutral insdk/src/auth/authMiddleware.ts.0600viafs.writeFile(..., { encoding: 'utf-8', mode: 0o600 })insdk/src/storage/file.ts.Testing
npm run lint --workspace sdk, which failed because the environment is missing the@typescript-eslint/eslint-plugindependency (external to these changes).npm run tsc --workspace sdk, which failed due to a pre-existing TypeScript error insdk/src/startRiseactApp.tsunrelated to the security edits in this PR.Codex Task