Skip to content

chore(security): redact sensitive auth logs and tighten credential file permissions #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielecirio wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(security): redact sensitive auth logs and tighten credential file permissions #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/src/auth/authMiddleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const authMiddleware: RequestHandler = safeAsyncHandler(async (req: Request, res
const credentials = await storage.getCredentialsByClientToken(token);

if (!credentials) {
console.info(`[RISEACT-SDK] No credentials found in storage for token ${token}, redirecting to riseact accounts authorize page`);
console.info('[RISEACT-SDK] No credentials found in storage for provided client token, redirecting to riseact accounts authorize page');
// return res.redirect(authorizePageUrl);
return res.status(401).send('Invalid client token');
}
Expand Down
8 changes: 3 additions & 5 deletions sdk/src/auth/callbackHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ const oauthCallbackHandler: RequestHandler = safeAsyncHandler(async (req: Reques
.catch((e) => {
console.error('[RISEACT-SDK] Error during OAuth callback with Riseact accounts server. Details below:', e, {
callbackParams: params,
codeVerifier: storedState.codeVerifier,
});
});

Expand All @@ -60,13 +59,12 @@ const oauthCallbackHandler: RequestHandler = safeAsyncHandler(async (req: Reques

if (!refreshToken || !accessToken || !expiresInSeconds) {
console.error('[RISEACT-SDK] No refresh_token, access_token or expires_in provided from authorization server. Details below:', {
refreshToken,
accessToken,
hasRefreshToken: !!refreshToken,
hasAccessToken: !!accessToken,
expiresInSeconds,
riseactConfig: config,
callbackParams: params,
codeVerifierCookie: storedState,
tokenSet,
hasCodeVerifier: !!storedState.codeVerifier,
});
return res.sendStatus(500);
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/src/auth/sidExchange.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const sidExchangeHandler: RequestHandler = safeAsyncHandler(async (req: Request,
// console.error('[RISEACT-SDK] Organization domain mismatch in SID exchange request');
// return res.status(400).send('Organization domain mismatch');
// }
console.debug('[RISEACT-SDK] SID exchange successful>', { sid, token });
console.debug('[RISEACT-SDK] SID exchange successful>', { sid, organizationDomain: token.organizationDomain });
return res.json({
client_token: token.clientToken,
organization: token.organizationDomain,
Expand Down
2 changes: 1 addition & 1 deletion sdk/src/storage/file.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ async function readStore(): Promise<Record<string, StoredOrg>> {

async function writeStore(store: Record<string, StoredOrg>): Promise<void> {
const tmp = `${CREDENTIALS_FILE}.tmp`;
await fs.writeFile(tmp, JSON.stringify(store, null, 2), 'utf-8');
await fs.writeFile(tmp, JSON.stringify(store, null, 2), { encoding: 'utf-8', mode: 0o600 });
await fs.rename(tmp, CREDENTIALS_FILE); // atomic swap
}

Expand Down
4 changes: 2 additions & 2 deletions sdk/src/utils/lruCache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export const pkceStore = new LRUCache<string, PkceRecord>({
});

export function savePkce(state: string, rec: PkceRecord) {
console.info('[RISEACT-SDK] Saving PKCE record', { state, rec });
console.info('[RISEACT-SDK] Saving PKCE record', { state, organizationDomain: rec.organizationDomain });
pkceStore.set(state, rec);
}

Expand All @@ -30,7 +30,7 @@ export const sidStore = new LRUCache<string, SidRecord>({
});

export function saveSid(state: string, rec: SidRecord) {
console.info('[RISEACT-SDK] Saving SID record', { state, rec });
console.info('[RISEACT-SDK] Saving SID record', { state, organizationDomain: rec.organizationDomain });
sidStore.set(state, rec);
}

Expand Down