Remove table_name requirement from AI chart generation frontend#1639
Merged
Conversation
Backend now autonomously discovers relevant tables, so the frontend no longer needs to fetch tables or show a table selector for AI generation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the frontend “table selection” requirement from AI chart generation, aligning the UI/service contract with the updated backend behavior where relevant tables are discovered automatically.
Changes:
- Updated
DashboardsService.generateWidgetWithAito remove thetableNameargument and no longer send it as a query param. - Simplified
ChartEditComponentAI generation flow by removing table-fetching prerequisites and the table selector UI. - Cleaned up related CSS for the removed AI table selector field.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
frontend/src/app/services/dashboards.service.ts |
Drops tableName from the AI widget generation API call signature and request params. |
frontend/src/app/components/charts/chart-edit/chart-edit.component.ts |
Removes table prerequisites and updates AI generation callsite to match the new service signature. |
frontend/src/app/components/charts/chart-edit/chart-edit.component.html |
Removes the table selector and shows the AI section based only on dashboard availability. |
frontend/src/app/components/charts/chart-edit/chart-edit.component.css |
Removes styling for the deleted .ai-table-field. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backend now autonomously discovers relevant tables, so the frontend no longer needs to fetch tables or show a table selector for AI generation.