Skip to content

Remove table_name requirement from AI chart generation frontend #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gugu merged 1 commit into from
Feb 26, 2026
Merged

Remove table_name requirement from AI chart generation frontend #1639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions frontend/src/app/components/charts/chart-edit/chart-edit.component.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,17 +140,6 @@
}
}

.ai-table-field {
flex: 0 0 220px;
}

@media (width <= 600px) {
.ai-table-field {
flex: 1;
width: 100%;
}
}

.ai-description-field {
flex: 1;
}
Expand Down
15 changes: 1 addition & 14 deletions frontend/src/app/components/charts/chart-edit/chart-edit.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ <h1 class="mat-h1">{{ isEditMode() ? 'Edit panel' : 'Create panel' }}</h1>

@if (!loading()) {
<div class="chart-edit-content">
@if (aiTables().length > 0 && aiDashboardId()) {
@if (aiDashboardId()) {
<div class="ai-section" [class.ai-section--collapsed]="!aiExpanded()">
<div class="ai-section-header" (click)="aiExpanded.set(!aiExpanded())">
<div class="ai-section-title">
Expand All @@ -33,19 +33,6 @@ <h1 class="mat-h1">{{ isEditMode() ? 'Edit panel' : 'Create panel' }}</h1>
@if (aiExpanded()) {
<div class="ai-section-body">
<div class="ai-fields">
<mat-form-field appearance="outline" class="ai-table-field">
<mat-label>Table</mat-label>
<mat-select
[ngModel]="aiTableName()"
(ngModelChange)="aiTableName.set($event)"
data-testid="ai-table-select">
@for (table of aiTables(); track table.table) {
<mat-option [value]="table.table">{{ table.display_name || table.table }}</mat-option>
}
</mat-select>
<mat-hint>Select the table to generate a chart for</mat-hint>
</mat-form-field>

<mat-form-field appearance="outline" class="ai-description-field">
<mat-label>Chart description</mat-label>
<textarea matInput
Expand Down
23 changes: 4 additions & 19 deletions frontend/src/app/components/charts/chart-edit/chart-edit.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import { ActivatedRoute, Router, RouterModule } from '@angular/router';
import { CodeEditorModule } from '@ngstack/code-editor';
import { Angulartics2 } from 'angulartics2';
import posthog from 'posthog-js';
import { firstValueFrom } from 'rxjs';
import { DEFAULT_COLOR_PALETTE } from 'src/app/lib/chart-config.helper';
import {
ChartAxisConfig,
Expand All @@ -30,11 +29,9 @@ import {
GeneratedPanelWithPosition,
TestQueryResult,
} from 'src/app/models/saved-query';
import { TableProperties } from 'src/app/models/table';
import { ConnectionsService } from 'src/app/services/connections.service';
import { DashboardsService } from 'src/app/services/dashboards.service';
import { SavedQueriesService } from 'src/app/services/saved-queries.service';
import { TablesService } from 'src/app/services/tables.service';
import { UiSettingsService } from 'src/app/services/ui-settings.service';
import { DashboardsSidebarComponent } from '../../dashboards/dashboards-sidebar/dashboards-sidebar.component';
import { AlertComponent } from '../../ui-components/alert/alert.component';
Expand Down Expand Up @@ -131,13 +128,11 @@ export class ChartEditComponent implements OnInit {

// AI generation
protected aiDescription = signal('');
protected aiTableName = signal('');
protected aiGenerating = signal(false);
protected aiTables = signal<TableProperties[]>([]);
protected aiDashboardId = signal<string | null>(null);
protected aiExpanded = signal(true);
protected manualExpanded = signal(false);
protected canGenerate = computed(() => !!this.aiDescription().trim() && !!this.aiTableName() && !this.aiGenerating());
protected canGenerate = computed(() => !!this.aiDescription().trim() && !this.aiGenerating());

public chartTypes: { value: ChartType; label: string }[] = [
{ value: 'bar', label: 'Bar Chart' },
Expand Down Expand Up @@ -374,7 +369,6 @@ export class ChartEditComponent implements OnInit {
private _savedQueries = inject(SavedQueriesService);
private _connections = inject(ConnectionsService);
private _dashboards = inject(DashboardsService);
private _tables = inject(TablesService);
private _uiSettings = inject(UiSettingsService);
private route = inject(ActivatedRoute);
private router = inject(Router);
Expand Down Expand Up @@ -645,12 +639,12 @@ export class ChartEditComponent implements OnInit {

async generateWithAi(): Promise<void> {
const dashboardId = this.aiDashboardId();
if (!dashboardId || !this.aiTableName() || !this.aiDescription().trim()) return;
if (!dashboardId || !this.aiDescription().trim()) return;

this.aiGenerating.set(true);

try {
const result = await this._dashboards.generateWidgetWithAi(dashboardId, this.connectionId(), this.aiTableName(), {
const result = await this._dashboards.generateWidgetWithAi(dashboardId, this.connectionId(), {
chart_description: this.aiDescription(),
});

Expand Down Expand Up @@ -722,19 +716,10 @@ export class ChartEditComponent implements OnInit {
}
}

private async _loadAiPrerequisites(): Promise<void> {
private _loadAiPrerequisites(): void {
const connectionId = this.connectionId();
if (!connectionId) return;

try {
const tables = await firstValueFrom(this._tables.fetchTables(connectionId));
if (tables?.length) {
this.aiTables.set(tables);
}
} catch {
// Tables loading failed - AI feature will be unavailable
}

// Trigger dashboards loading; the effect in constructor picks up the result
this._dashboards.setActiveConnection(connectionId);
}
Expand Down
2 changes: 0 additions & 2 deletions frontend/src/app/services/dashboards.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,13 +142,11 @@ export class DashboardsService {
async generateWidgetWithAi(
dashboardId: string,
connectionId: string,
tableName: string,
payload: { chart_description: string; name?: string },
): Promise<GeneratedPanelWithPosition | null> {
return this._api.post<GeneratedPanelWithPosition>(
`/dashboard/${dashboardId}/widget/generate/${connectionId}`,
payload,
{ params: { tableName } },
);
}

Expand Down
Loading