Skip to content

Modernize rttest and tlsf_cpp for C++20 part 2#148

Open
ahcorde wants to merge 4 commits into
rollingfrom
ahcorde/rolling/improvements_part3
Open

Modernize rttest and tlsf_cpp for C++20 part 2#148
ahcorde wants to merge 4 commits into
rollingfrom
ahcorde/rolling/improvements_part3

Conversation

@ahcorde

@ahcorde ahcorde commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Description

  • replaced the #define NSEC_PER_SEC macro with a typed static constexpr int64_t constant
  • marked all seven timespec helpers constexpr

Did you use Generative AI?

Claude Opus 4.7

ahcorde added 3 commits June 16, 2026 17:39
…structor

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from asymingt June 16, 2026 15:59
@ahcorde ahcorde self-assigned this Jun 16, 2026

@asymingt asymingt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from ahcorde/rolling/improvements_part2 to rolling June 19, 2026 07:12
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde

ahcorde commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Pulls: #148
Gist: https://gist.githubusercontent.com/ahcorde/63d07c129b47d4303f2f765452b2c908/raw/796b57a3eaf5abacdc824d6a27d9b86dcff2aaff/ros2.repos
BUILD args: --packages-above-and-dependencies rttest tlsf_cpp
TEST args: --packages-above rttest tlsf_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19610

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants